From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C8DC433E0 for ; Thu, 21 Jan 2021 07:08:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE0AB23877 for ; Thu, 21 Jan 2021 07:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0AB23877 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E952C6B0005; Thu, 21 Jan 2021 02:08:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E626B0007; Thu, 21 Jan 2021 02:08:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D7A6B0008; Thu, 21 Jan 2021 02:08:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id B807F6B0005 for ; Thu, 21 Jan 2021 02:08:39 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 775A3181AEF39 for ; Thu, 21 Jan 2021 07:08:39 +0000 (UTC) X-FDA: 77728904358.17.side67_0d0aa4e27561 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 5587C180D0181 for ; Thu, 21 Jan 2021 07:08:39 +0000 (UTC) X-HE-Tag: side67_0d0aa4e27561 X-Filterd-Recvd-Size: 1604 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 07:08:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 7A8DE67357; Thu, 21 Jan 2021 08:08:35 +0100 (CET) Date: Thu, 21 Jan 2021 08:08:35 +0100 From: Christoph Hellwig To: Rick Edgecombe Cc: akpm@linux-foundation.org, hch@lst.de, dja@axtens.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: Separate put pages and flush VM flags Message-ID: <20210121070835.GA23327@lst.de> References: <20210121014118.31922-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121014118.31922-1-rick.p.edgecombe@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 20, 2021 at 05:41:18PM -0800, Rick Edgecombe wrote: > When VM_MAP_PUT_PAGES was added, it was defined with the same value as > VM_FLUSH_RESET_PERMS. This doesn't seem like it will cause any big > functional problems other than some excess flushing for VM_MAP_PUT_PAGES > allocations. > > Redefine VM_MAP_PUT_PAGES to have its own value. Also, move the comment > and remove whitespace for VM_KASAN such that the flags lower down are less > likely to be missed in the future. > > Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap") > Signed-off-by: Rick Edgecombe Ooops. Looks good: Reviewed-by: Christoph Hellwig