From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <smatch-owner@vger.kernel.org>
Received: from userp2130.oracle.com ([156.151.31.86]:35262 "EHLO
        userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727818AbhAUIup (ORCPT
        <rfc822;smatch@vger.kernel.org>); Thu, 21 Jan 2021 03:50:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : mime-version : content-type :
 in-reply-to; s=corp-2020-01-29;
 bh=tmQeV47X5c9mojaDyBOAOdhvCBFr+/NZU+jMiUiYiK8=;
 b=SznwzWAawtLJuHVCm6lzzGFO4HP3SJO9QB6HuvIsrQdMh3APMHZJxXM0voukVeYnMry1
 6IKpkhKx7cTEsatbk2e2vY5tbYu1gQuEAfGCSbo6HGMFOBEgJhv9n/opCCs23pQbpne2
 RW/sQJiqIlT4VlcvSNPfzI+LvZAC9qIVrgswHc4N3KPtLRRC7rkzXNtjWuqFz3cjv6uo
 ATu7ouBuT/o3negu4kJE/PAtCMO2CfbfBFoy3hkz+qT3aOdogj1gVuelzf3cZDbYUO0u
 DYU3NLaBqCoFkx2Rv526MX6FDP4xOadhbuFEgRO5Tt2ipXNb7eO4CVYh0fQsE9saVHqT 8Q== 
Date: Thu, 21 Jan 2021 11:49:49 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: Intel i40e code finds smatch bug
Message-ID: <20210121084949.GQ2696@kadam>
References: <38E556EE-C173-4935-80DF-51DC4FE8C90E@joyent.com>
 <20210119185547.GN2696@kadam>
 <47367857-0F08-459A-84FE-4FD35B009AB3@joyent.com>
 <20210119214221.6cgngihmjrrot56t@ltop.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210119214221.6cgngihmjrrot56t@ltop.local>
List-ID: <smatch.vger.kernel.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Dan McDonald <danmcd@joyent.com>, smatch@vger.kernel.org

On Tue, Jan 19, 2021 at 10:42:21PM +0100, Luc Van Oostenryck wrote:
> On Tue, Jan 19, 2021 at 03:51:57PM -0500, Dan McDonald wrote:
> > On Jan 19, 2021, at 1:55 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > > 
> > > Luk recently was working on better support of packed structs (which have
> > > been a known issue for a while) but I doubt that will help here.
> 
> Indeed, the support for packed structs (via the attribute) is now
> complete in Sparse and was mainlined 2 weeks ago or so and ...
>  
> > I tried using packed struct attributes instead of the pragma and no luck there either:
> 
> now it just needs to be merged into smatch.
>  

Awesome!  I've merged it and will push the merge tomorrow if the tests
run well tonight.  Thanks!

regards,
dan carpenter