From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethtool: allow MAC drivers to override ethtool get_ts_info
Date: Thu, 21 Jan 2021 10:27:38 +0000 [thread overview]
Message-ID: <20210121102738.GN1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210121040451.GB14465@hoboy.vegasvil.org>
On Wed, Jan 20, 2021 at 08:04:51PM -0800, Richard Cochran wrote:
> On Thu, Jan 14, 2021 at 10:38:00PM +0000, Russell King - ARM Linux admin wrote:
>
> > So, I think the only way to prevent a regression with the code as
> > it is today is that we _never_ support PTP on Marvell PHYs - because
> > doing so _will_ break the existing MVPP2 driver's implementation and
> > cause a regression.
>
> The situation isn't as bad as it seems.
>
> For one thing, mvpp2 incorrectly selects NETWORK_PHY_TIMESTAMPING.
> It really shouldn't. I'm submitting a fix soon.
>
> As long as the new PHY driver (or at least the PTP bit) depends on
> NETWORK_PHY_TIMESTAMPING, then that allows users who _really_ want
> that to enable the option at compile time. This option adds extra
> checks into the networking hot path, and almost everyone should avoid
> enabling it.
As I already explained to you, you can *NOT* use kernel configuration
to make the choice. ARM is a multi-platform kernel, and we will not
stand for platform choices dictated by kernel configuration options.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-01-21 13:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 11:13 [PATCH net-next] net: ethtool: allow MAC drivers to override ethtool get_ts_info Russell King
2021-01-10 16:35 ` Andrew Lunn
2021-01-14 3:05 ` Jakub Kicinski
2021-01-14 17:09 ` Russell King - ARM Linux admin
2021-01-14 17:27 ` Russell King - ARM Linux admin
2021-01-14 12:55 ` Richard Cochran
2021-01-14 13:22 ` Russell King - ARM Linux admin
2021-01-14 13:32 ` Russell King - ARM Linux admin
2021-01-14 17:27 ` Richard Cochran
2021-01-14 17:31 ` Russell King - ARM Linux admin
2021-01-14 22:38 ` Russell King - ARM Linux admin
2021-01-21 4:04 ` Richard Cochran
2021-01-21 10:27 ` Russell King - ARM Linux admin [this message]
2021-01-21 15:06 ` Richard Cochran
2021-01-21 16:22 ` Andrew Lunn
2021-01-21 17:03 ` Richard Cochran
2021-01-21 18:55 ` Andrew Lunn
2021-01-21 22:59 ` Russell King - ARM Linux admin
2021-01-21 18:18 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121102738.GN1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.