Re: [PATCH 1/3] btf_encoder: Fix handling of restrict qualifier

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Wed, Jan 20, 2021 at 11:07:44PM -0800, Andrii Nakryiko escreveu:
> On Mon, Jan 18, 2021 at 8:01 AM Giuliano Procida <gprocida@google.com> wrote:
> >
> > Fixes: 48efa92933e8 ("btf_encoder: Use libbpf APIs to encode BTF type info")
> >
> > Signed-off-by: Giuliano Procida <gprocida@google.com>
> > ---
> 
> It's up to the maintainer, but some short commit message would be
> welcome. Also, it would be nice to have [PATCH dwarves] to distinguish
> this from patches targeted to bpf/bpf-next tree.

Yeah, this one looks obvious so I'll add the comment myself, please do
it next time.

- Arnaldo
 
> The fix itself looks good:
> 
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
> 
> >  libbtf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libbtf.c b/libbtf.c
> > index 16e1d45..3709087 100644
> > --- a/libbtf.c
> > +++ b/libbtf.c
> > @@ -417,7 +417,7 @@ int32_t btf_elf__add_ref_type(struct btf_elf *btfe, uint16_t kind, uint32_t type
> >                 id = btf__add_const(btf, type);
> >                 break;
> >         case BTF_KIND_RESTRICT:
> > -               id = btf__add_const(btf, type);
> > +               id = btf__add_restrict(btf, type);
> >                 break;
> >         case BTF_KIND_TYPEDEF:
> >                 id = btf__add_typedef(btf, name, type);
> > --
> > 2.30.0.284.gd98b1dd5eaa7-goog
> >

-- 

- Arnaldo