From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: paulmck@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
kernel-team@fb.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings
Date: Thu, 21 Jan 2021 17:42:52 -0500 [thread overview]
Message-ID: <20210121224252.GQ16838@windriver.com> (raw)
In-Reply-To: <CAAH8bW8-q-2LaTC5DE0PnUBqs3V_69EAefLvwdZoeFSow8NYZA@mail.gmail.com>
[Re: [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings] On 20/01/2021 (Wed 23:11) Yury Norov wrote:
> Hi Paul,
>
> Today I found this series in linux-next despite downsides discovered during
> the review. This series introduces absolutely unneeded cap on the number of
> cpus in the system (9999), and also adds unsafe and non-optimal code.
>
> In addition to that, I observe this warning on powerpc:
> CC lib/cpumask.o
> lib/cpumask.c: In function ‘cpulist_parse’:
> lib/cpumask.c:222:17: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
> 222 | memblock_free((phys_addr_t)cpulist, len);
> | ^
>
> Can you please revert this series unless all the problems will be fixed?
That was my fault - I should have explicitly asked PaulM to yank it once
I didn't get to creating v2 immediately. Sorry.
Your suggested changes made things much more simple and smaller - thanks!
I believe v2 does address all the problems - please have a look when you
have some time. It should be easier to review, given the smaller size.
https://lore.kernel.org/lkml/20210121223355.59780-1-paul.gortmaker@windriver.com/
Thanks again,
Paul.
--
>
> Thanks,
> Yury
prev parent reply other threads:[~2021-01-21 22:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 0:48 [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings Paul E. McKenney
2021-01-06 0:49 ` [PATCH RFC cpumask 1/5] cpumask: Un-inline cpulist_parse for SMP; prepare for ascii helpers paulmck
2021-01-06 0:49 ` [PATCH RFC cpumask 2/5] cpumask: Make "all" alias global and not just RCU paulmck
2021-01-06 6:32 ` Yury Norov
2021-01-06 0:49 ` [PATCH RFC cpumask 3/5] cpumask: Add a "none" alias to complement "all" paulmck
2021-01-06 6:59 ` Yury Norov
2021-01-06 0:49 ` [PATCH RFC cpumask 4/5] cpumask: Add "last" alias for cpu list specifications paulmck
2021-01-06 8:41 ` Yury Norov
2021-01-06 9:49 ` Peter Zijlstra
2021-01-06 17:45 ` Paul Gortmaker
2021-01-06 21:16 ` Yury Norov
2021-01-07 14:18 ` Peter Zijlstra
2021-01-07 14:47 ` Paul E. McKenney
2021-01-07 14:59 ` Peter Zijlstra
2021-01-07 15:32 ` Paul E. McKenney
2021-01-07 15:05 ` Paul E. McKenney
2021-01-06 0:49 ` [PATCH RFC cpumask 5/5] rcutorture: Use "all" and "last" in "nohz_full" and "rcu_nocbs" paulmck
2021-01-06 8:49 ` [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings Yury Norov
2021-01-21 7:11 ` Yury Norov
2021-01-21 16:57 ` Paul E. McKenney
2021-01-21 21:39 ` Paul E. McKenney
2021-01-21 22:42 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121224252.GQ16838@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.