From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [linux-next:master 2717/5111] drivers/gpu/drm/i915/gt/intel_region_lmem.c:42 init_fake_lmem_bar() warn: should 'n << 12' be a 64 bit
Date: Fri, 22 Jan 2021 02:33:25 +0800 [thread overview]
Message-ID: <202101220211.xpRa42Z8-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 6026 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Matthew Auld <matthew.auld@intel.com>
CC: Chris Wilson <chris@chris-wilson.co.uk>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: bc085f8fc88fc16796c9f2364e2bfb3fef305cad
commit: f178b89743867255b3946b40b640f379c3961c09 [2717/5111] drm/i915: move region_lmem under gt
:::::: branch date: 11 hours ago
:::::: commit date: 9 days ago
config: i386-randconfig-m021-20210121 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/gt/intel_region_lmem.c:42 init_fake_lmem_bar() warn: should 'n << 12' be a 64 bit type?
vim +42 drivers/gpu/drm/i915/gt/intel_region_lmem.c
b908be543e444147 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-25 11
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 12 static int init_fake_lmem_bar(struct intel_memory_region *mem)
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 13 {
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 14 struct drm_i915_private *i915 = mem->i915;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 15 struct i915_ggtt *ggtt = &i915->ggtt;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 16 unsigned long n;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 17 int ret;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 18
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 19 /* We want to 1:1 map the mappable aperture to our reserved region */
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 20
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 21 mem->fake_mappable.start = 0;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 22 mem->fake_mappable.size = resource_size(&mem->region);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 23 mem->fake_mappable.color = I915_COLOR_UNEVICTABLE;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 24
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 25 ret = drm_mm_reserve_node(&ggtt->vm.mm, &mem->fake_mappable);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 26 if (ret)
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 27 return ret;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 28
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 29 mem->remap_addr = dma_map_resource(&i915->drm.pdev->dev,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 30 mem->region.start,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 31 mem->fake_mappable.size,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 32 PCI_DMA_BIDIRECTIONAL,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 33 DMA_ATTR_FORCE_CONTIGUOUS);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 34 if (dma_mapping_error(&i915->drm.pdev->dev, mem->remap_addr)) {
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 35 drm_mm_remove_node(&mem->fake_mappable);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 36 return -EINVAL;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 37 }
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 38
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 39 for (n = 0; n < mem->fake_mappable.size >> PAGE_SHIFT; ++n) {
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 40 ggtt->vm.insert_page(&ggtt->vm,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 41 mem->remap_addr + (n << PAGE_SHIFT),
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 @42 n << PAGE_SHIFT,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 43 I915_CACHE_NONE, 0);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 44 }
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 45
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 46 mem->region = (struct resource)DEFINE_RES_MEM(mem->remap_addr,
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 47 mem->fake_mappable.size);
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 48
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 49 return 0;
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 50 }
1629224324b6cab6 drivers/gpu/drm/i915/intel_region_lmem.c Matthew Auld 2019-10-30 51
:::::: The code at line 42 was first introduced by commit
:::::: 1629224324b6cab6f7f96e839c9b57b74cfd8349 drm/i915/lmem: add the fake lmem region
:::::: TO: Matthew Auld <matthew.auld@intel.com>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36070 bytes --]
reply other threads:[~2021-01-21 18:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101220211.xpRa42Z8-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.