From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon
Date: Fri, 22 Jan 2021 08:54:08 +0000 [thread overview]
Message-ID: <20210122085408.4fcc8a10@archlinux> (raw)
In-Reply-To: <20210120204824.0d52a2d2@archlinux>
On Wed, 20 Jan 2021 20:49:57 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 29 Dec 2020 18:18:41 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Mon, 14 Dec 2020 06:13:58 -0800
> > Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> >
> > > On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote:
> > > > Replace a comma between expression statements by a semicolon.
> > > >
> > > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Applied to the togreg branch of iio.git and pushed out as testing for
> > the autobuilders to see if they can break it.
> Hi Jiri,
>
> Just realised this is in HID rather than IIO. I hope you don't mind as
> it's now deep in a tree I'd rather not rebase.
On basis it wasn't actually that bad, (only one merge after it) I did
the rebase and dropped this patch. Jiri, guess you probably
want to pick this up through HID.
Thanks,
Jonathan
>
> Sorry about that.
>
> Jonathan
>
> >
> > Thanks,
> >
> > Jonathan
> >
> > >
> > > > ---
> > > > drivers/hid/hid-sensor-custom.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > > > sensor-custom.c
> > > > index 4d25577a8573..6c47a2e7623d 100644
> > > > --- a/drivers/hid/hid-sensor-custom.c
> > > > +++ b/drivers/hid/hid-sensor-custom.c
> > > > @@ -728,7 +728,7 @@ static int hid_sensor_custom_dev_if_add(struct
> > > > hid_sensor_custom *sensor_inst)
> > > >
> > > > sensor_inst->custom_dev.minor = MISC_DYNAMIC_MINOR;
> > > > sensor_inst->custom_dev.name = dev_name(&sensor_inst->pdev-
> > > > >dev);
> > > > - sensor_inst->custom_dev.fops = &hid_sensor_custom_fops,
> > > > + sensor_inst->custom_dev.fops = &hid_sensor_custom_fops;
> > > > ret = misc_register(&sensor_inst->custom_dev);
> > > > if (ret) {
> > > > kfifo_free(&sensor_inst->data_fifo);
> > >
> > >
> >
>
next prev parent reply other threads:[~2021-01-22 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 13:32 [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon Zheng Yongjun
2020-12-14 14:13 ` Srinivas Pandruvada
2020-12-29 18:18 ` Jonathan Cameron
2021-01-20 20:49 ` Jonathan Cameron
2021-01-22 8:54 ` Jonathan Cameron [this message]
2021-01-22 10:58 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122085408.4fcc8a10@archlinux \
--to=jic23@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.