From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3511166873942224009==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] printk: fix returnvar.cocci warnings Date: Fri, 22 Jan 2021 17:03:28 +0800 Message-ID: <20210122090328.GA150135@2584c2cb903b> In-Reply-To: <202101221725.Qvm7wHNy-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============3511166873942224009== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: John Ogness CC: Sebastian Andrzej Siewior CC: Petr Mladek CC: Sergey Senozhatsky CC: Steven Rostedt CC: linux-kernel(a)vger.kernel.org From: kernel test robot kernel/printk/printk.c:2127:5-8: Unneeded variable: "ret". Return "- ENOMEM= " on line 2226 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 42afcbce7b62 ("printk: move console printing to kthreads") CC: John Ogness Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.g= it linux-5.11.y-rt-rebase head: 4a7805e223e04660df86d5ca0d16f1acdd3c91eb commit: 42afcbce7b62cd3e1bb00468ff150281d68dd8ee [34/184] printk: move cons= ole printing to kthreads :::::: branch date: 20 hours ago :::::: commit date: 20 hours ago Please take the patch only if it's a positive warning. Thanks! printk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2124,7 +2124,6 @@ static int printk_kthread_func(void *dat struct printk_record r; char *ext_text =3D NULL; size_t dropped_len; - int ret =3D -ENOMEM; char *text =3D NULL; char *write_text; u64 printk_seq; @@ -2223,7 +2222,7 @@ out: pr_info("%sconsole [%s%d]: printing thread stopped\n", (con->flags & CON_BOOT) ? "boot" : "", con->name, con->index); - return ret; + return -ENOMEM; } = /* Must be called within console_lock(). */ --===============3511166873942224009==--