From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [ath6kl:pending 10/12] drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL. 'sar->sub_specs'
Date: Fri, 22 Jan 2021 11:34:58 +0800 [thread overview]
Message-ID: <202101221151.HGS9PT1b-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4651 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Kalle Valo <kvalo@codeaurora.org>
CC: ath10k(a)lists.infradead.org
TO: Carl Huang <cjhuang@codeaurora.org>
CC: Kalle Valo <kvalo@codeaurora.org>
CC: Brian Norris <briannorris@chromium.org>
CC: Abhishek Kumar <kuabhs@chromium.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
head: 13112a10a90ece17774a25bc363a7561c26aa19f
commit: c995c0bdf2d68ce279507a2017e1e65e823339df [10/12] ath10k: allow dynamic SAR power limits via common API
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-m001-20210121 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL. 'sar->sub_specs'
Old smatch warnings:
drivers/net/wireless/ath/ath10k/mac.c:5150 ath10k_start() warn: missing error code 'ret'
drivers/net/wireless/ath/ath10k/mac.c:5589 ath10k_add_interface() warn: missing error code 'ret'
vim +3010 drivers/net/wireless/ath/ath10k/mac.c
c995c0bdf2d68ce Carl Huang 2021-01-18 2993
c995c0bdf2d68ce Carl Huang 2021-01-18 2994 static int ath10k_mac_set_sar_specs(struct ieee80211_hw *hw,
c995c0bdf2d68ce Carl Huang 2021-01-18 2995 const struct cfg80211_sar_specs *sar)
c995c0bdf2d68ce Carl Huang 2021-01-18 2996 {
c995c0bdf2d68ce Carl Huang 2021-01-18 2997 const struct cfg80211_sar_sub_specs *sub_specs;
c995c0bdf2d68ce Carl Huang 2021-01-18 2998 struct ath10k *ar = hw->priv;
c995c0bdf2d68ce Carl Huang 2021-01-18 2999 u32 i;
c995c0bdf2d68ce Carl Huang 2021-01-18 3000 int ret;
c995c0bdf2d68ce Carl Huang 2021-01-18 3001
c995c0bdf2d68ce Carl Huang 2021-01-18 3002 mutex_lock(&ar->conf_mutex);
c995c0bdf2d68ce Carl Huang 2021-01-18 3003
c995c0bdf2d68ce Carl Huang 2021-01-18 3004 if (!ar->hw_params.dynamic_sar_support) {
c995c0bdf2d68ce Carl Huang 2021-01-18 3005 ret = -EOPNOTSUPP;
c995c0bdf2d68ce Carl Huang 2021-01-18 3006 goto error;
c995c0bdf2d68ce Carl Huang 2021-01-18 3007 }
c995c0bdf2d68ce Carl Huang 2021-01-18 3008
c995c0bdf2d68ce Carl Huang 2021-01-18 3009 if (!sar || sar->type != NL80211_SAR_TYPE_POWER ||
c995c0bdf2d68ce Carl Huang 2021-01-18 @3010 sar->num_sub_specs == 0 || !sar->sub_specs) {
c995c0bdf2d68ce Carl Huang 2021-01-18 3011 ret = -EINVAL;
c995c0bdf2d68ce Carl Huang 2021-01-18 3012 goto error;
c995c0bdf2d68ce Carl Huang 2021-01-18 3013 }
c995c0bdf2d68ce Carl Huang 2021-01-18 3014
c995c0bdf2d68ce Carl Huang 2021-01-18 3015 sub_specs = sar->sub_specs;
c995c0bdf2d68ce Carl Huang 2021-01-18 3016
c995c0bdf2d68ce Carl Huang 2021-01-18 3017 /* 0dbm is not a practical value for ath10k, so use 0
c995c0bdf2d68ce Carl Huang 2021-01-18 3018 * as no SAR limitation on it.
c995c0bdf2d68ce Carl Huang 2021-01-18 3019 */
c995c0bdf2d68ce Carl Huang 2021-01-18 3020 ar->tx_power_2g_limit = 0;
c995c0bdf2d68ce Carl Huang 2021-01-18 3021 ar->tx_power_5g_limit = 0;
c995c0bdf2d68ce Carl Huang 2021-01-18 3022
c995c0bdf2d68ce Carl Huang 2021-01-18 3023 /* note the power is in 0.25dbm unit, while ath10k uses
c995c0bdf2d68ce Carl Huang 2021-01-18 3024 * 0.5dbm unit.
c995c0bdf2d68ce Carl Huang 2021-01-18 3025 */
c995c0bdf2d68ce Carl Huang 2021-01-18 3026 for (i = 0; i < sar->num_sub_specs; i++) {
c995c0bdf2d68ce Carl Huang 2021-01-18 3027 if (sub_specs->freq_range_index == 0)
c995c0bdf2d68ce Carl Huang 2021-01-18 3028 ar->tx_power_2g_limit = sub_specs->power / 2;
c995c0bdf2d68ce Carl Huang 2021-01-18 3029 else if (sub_specs->freq_range_index == 1)
c995c0bdf2d68ce Carl Huang 2021-01-18 3030 ar->tx_power_5g_limit = sub_specs->power / 2;
c995c0bdf2d68ce Carl Huang 2021-01-18 3031
c995c0bdf2d68ce Carl Huang 2021-01-18 3032 sub_specs++;
c995c0bdf2d68ce Carl Huang 2021-01-18 3033 }
c995c0bdf2d68ce Carl Huang 2021-01-18 3034
c995c0bdf2d68ce Carl Huang 2021-01-18 3035 ret = ath10k_mac_set_sar_power(ar);
c995c0bdf2d68ce Carl Huang 2021-01-18 3036 error:
c995c0bdf2d68ce Carl Huang 2021-01-18 3037 mutex_unlock(&ar->conf_mutex);
c995c0bdf2d68ce Carl Huang 2021-01-18 3038 return ret;
c995c0bdf2d68ce Carl Huang 2021-01-18 3039 }
c995c0bdf2d68ce Carl Huang 2021-01-18 3040
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38648 bytes --]
next reply other threads:[~2021-01-22 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 3:34 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-22 15:07 [ath6kl:pending 10/12] drivers/net/wireless/ath/ath10k/mac.c:3010 ath10k_mac_set_sar_specs() warn: this array is probably non-NULL. 'sar->sub_specs' Dan Carpenter
2021-01-22 15:07 ` Dan Carpenter
2021-01-22 15:07 ` Dan Carpenter
2021-01-27 10:52 ` Kalle Valo
2021-01-27 10:52 ` Kalle Valo
2021-01-27 10:58 ` Dan Carpenter
2021-01-27 10:58 ` Dan Carpenter
2021-01-27 10:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101221151.HGS9PT1b-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.