From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org,
david@redhat.com, bhe@redhat.com, lkp@intel.com
Subject: [PATCH v5 5/5] mm: remove unneeded local variable in free_area_init_core
Date: Fri, 22 Jan 2021 21:59:56 +0800 [thread overview]
Message-ID: <20210122135956.5946-6-bhe@redhat.com> (raw)
In-Reply-To: <20210122135956.5946-1-bhe@redhat.com>
Local variable 'zone_start_pfn' is not needed since there's only
one call site in free_area_init_core(). Let's remove it and pass
zone->zone_start_pfn directly to init_currently_empty_zone().
Signed-off-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
mm/page_alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 69cf19baac12..e0df67948ace 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6923,7 +6923,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
for (j = 0; j < MAX_NR_ZONES; j++) {
struct zone *zone = pgdat->node_zones + j;
unsigned long size, freesize, memmap_pages;
- unsigned long zone_start_pfn = zone->zone_start_pfn;
size = zone->spanned_pages;
freesize = zone->present_pages;
@@ -6972,7 +6971,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
set_pageblock_order();
setup_usemap(zone);
- init_currently_empty_zone(zone, zone_start_pfn, size);
+ init_currently_empty_zone(zone, zone->zone_start_pfn, size);
memmap_init_zone(zone);
}
}
--
2.17.2
next prev parent reply other threads:[~2021-01-22 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 13:59 [PATCH v5 0/5] mm: clean up names and parameters of memmap_init_xxxx functions Baoquan He
2021-01-22 13:59 ` [PATCH v5 1/5] mm: fix prototype warning from kernel test robot Baoquan He
2021-01-22 15:38 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 2/5] mm: rename memmap_init() and memmap_init_zone() Baoquan He
2021-01-22 15:38 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 3/5] mm: simplify parater of function memmap_init_zone() Baoquan He
2021-01-22 15:39 ` David Hildenbrand
2021-01-22 13:59 ` [PATCH v5 4/5] mm: simplify parameter of setup_usemap() Baoquan He
2021-01-22 13:59 ` Baoquan He [this message]
2021-01-22 18:12 ` [PATCH v5 0/5] mm: clean up names and parameters of memmap_init_xxxx functions Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122135956.5946-6-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.