From: Kevin Hao <haokexin@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>
Subject: [PATCH net-next 3/4] net: octeontx2: Use napi_alloc_frag_align() to avoid the memory waste
Date: Sat, 23 Jan 2021 19:59:02 +0800 [thread overview]
Message-ID: <20210123115903.31302-4-haokexin@gmail.com> (raw)
In-Reply-To: <20210123115903.31302-1-haokexin@gmail.com>
The napi_alloc_frag_align() will guarantee that a correctly align
buffer address is returned. So use this function to simplify the buffer
alloc and avoid the unnecessary memory waste.
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index e6869435e1f3..6fbceabae1ac 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -478,11 +478,10 @@ dma_addr_t __otx2_alloc_rbuf(struct otx2_nic *pfvf, struct otx2_pool *pool)
dma_addr_t iova;
u8 *buf;
- buf = napi_alloc_frag(pool->rbsize + OTX2_ALIGN);
+ buf = napi_alloc_frag_align(pool->rbsize, OTX2_ALIGN);
if (unlikely(!buf))
return -ENOMEM;
- buf = PTR_ALIGN(buf, OTX2_ALIGN);
iova = dma_map_single_attrs(pfvf->dev, buf, pool->rbsize,
DMA_FROM_DEVICE, DMA_ATTR_SKIP_CPU_SYNC);
if (unlikely(dma_mapping_error(pfvf->dev, iova))) {
--
2.29.2
next prev parent reply other threads:[~2021-01-23 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 11:58 [PATCH net-next 0/4] net: Avoid the memory waste in some Ethernet drivers Kevin Hao
2021-01-23 11:59 ` [PATCH net-next 1/4] mm: page_frag: Introduce page_frag_alloc_align() Kevin Hao
2021-01-23 20:52 ` Jakub Kicinski
2021-01-24 3:55 ` Kevin Hao
2021-01-26 16:19 ` Vlastimil Babka
2021-01-23 11:59 ` [PATCH net-next 2/4] net: Introduce {netdev,napi}_alloc_frag_align() Kevin Hao
2021-01-23 11:59 ` Kevin Hao [this message]
2021-01-23 11:59 ` [PATCH net-next 4/4] net: dpaa2: Use napi_alloc_frag_align() to avoid the memory waste Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123115903.31302-4-haokexin@gmail.com \
--to=haokexin@gmail.com \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.