All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/6] package/mrouted: for merged usr, install to /usr by default, not /
Date: Sat, 23 Jan 2021 21:57:38 +0100	[thread overview]
Message-ID: <20210123205738.GD926565@scaer> (raw)
In-Reply-To: <20210123103155.2599311-6-troglobit@gmail.com>

Joachim, All,

On 2021-01-23 11:31 +0100, Joachim Wiberg spake thusly:
> - Config in /etc
> - State files in /var
> - Binaries in /usr
> 
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
>  package/mrouted/mrouted.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mrouted/mrouted.mk b/package/mrouted/mrouted.mk
> index 9f52d1ca90..558efa946e 100644
> --- a/package/mrouted/mrouted.mk
> +++ b/package/mrouted/mrouted.mk
> @@ -10,7 +10,8 @@ MROUTED_SITE = \
>  MROUTED_DEPENDENCIES = host-bison
>  MROUTED_LICENSE = BSD-3-Clause
>  MROUTED_LICENSE_FILES = LICENSE
> -MROUTED_CONFIGURE_OPTS = --enable-rsrr
> +MROUTED_CONF_OPTS = --prefix=/usr --sysconfdir=/etc --localstatedir=/var

I don't understand why the above is needed, and how it is related to
merged-usr as stated in the commit title...

Indeed, the --prefix, --sysconfdir, and --localstatedir passed by the
autotools infra are already the values you pass above:

    https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n186

    ./configure \
        --target=$$(GNU_TARGET_NAME) \
        --host=$$(GNU_TARGET_NAME) \
        --build=$$(GNU_HOST_NAME) \
        --prefix=/usr \
        --exec-prefix=/usr \
        --sysconfdir=/etc \
        --localstatedir=/var \

So I am not sure why you need to pass those explicitly.

Furthermore, I don't see what a merged-usr setup would come into play
in this situation...

In the meantime, I've marked this patch as rejected in patchwork. If you
still believe it is needed, please respin with additional explanations:
what is the problem that you encountered, and why explicitly passing
those options solves it?

Thanks!

Regards,
Yann E. MORIN.

> +MROUTED_CONF_OPTS += --enable-rsrr
>  MROUTED_CPE_ID_VENDOR = troglobit
>  
>  define MROUTED_INSTALL_INIT_SYSV
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-01-23 20:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 10:31 [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 1/6] package/mrouted: bump to version 4.2 Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 2/6] package/mrouted: ensure multicast routing is enabled in kernel Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 3/6] package/mrouted: update description a bit, mention oper. requirement Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 4/6] package/mrouted: add sysv init script Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 5/6] package/mrouted: for merged usr, install to /usr by default, not / Joachim Wiberg
2021-01-23 20:57   ` Yann E. MORIN [this message]
2021-01-23 21:59     ` Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 6/6] package/mrouted: menuconfig support for enabling rsrr support Joachim Wiberg
2021-01-23 20:51   ` Yann E. MORIN
2021-01-23 22:02     ` Joachim Wiberg
2021-01-23 20:46 ` [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210123205738.GD926565@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.