From: Oliver Upton <oupton@google.com>
To: dbrazdil@google.com
Cc: hns@goldelico.com, linux-kernel@vger.kernel.org, maz@kernel.org,
sashal@kernel.org, Oliver Upton <oupton@google.com>
Subject: Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe
Date: Mon, 25 Jan 2021 20:07:56 +0000 [thread overview]
Message-ID: <20210125200756.1249239-1-oupton@google.com> (raw)
In-Reply-To: <20200914133626.hlsvu5kces3wsirr@google.com>
> That means we have two options:
> (a) define __hyp_panic_string in a different .c file in all pre-5.9 branches, or
> (b) revert the backported patch.
>
> The patch was needed in 5.9 and should stay there. It wasn't needed in earlier
> versions because the symbol was being kept alive by another user. It did "fix"
> the inline asm semantics, but the problem was never triggered in pre-5.9.
>
> Sasha, with this and the GCC bug in mind, would you agree that (b) is the
> better course of action?
Sasha,
Any chance we can get this patch reverted as David has suggested? It was
backported to 5.4 LTS in commit 653ae33b030b ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe")
and is causing build issues with a 4.9.4 vintage of GCC.
Thanks!
--
Oliver
next prev parent reply other threads:[~2021-01-25 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 13:29 [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe H. Nikolaus Schaller
2020-09-07 14:22 ` Sasha Levin
2020-09-07 14:42 ` H. Nikolaus Schaller
2020-09-14 13:36 ` David Brazdil
2021-01-25 20:07 ` Oliver Upton [this message]
2021-01-25 20:56 ` Marc Zyngier
2021-01-26 18:23 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125200756.1249239-1-oupton@google.com \
--to=oupton@google.com \
--cc=dbrazdil@google.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.