From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74AEC433E0 for ; Mon, 25 Jan 2021 21:42:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7C52083E for ; Mon, 25 Jan 2021 21:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7C52083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rJsezWQj9iIbeA4c/XhYymDatguiAbLBAy8jTyaTBv4=; b=ksTGUZFBrMZquWX7aY/QeI9L2 UMD7lLIwsdLF3zkpTHf+il58jQ6j40NZdb8cYhIK5YoHZghekNKR5XtatXN7Fdgd4e4Il03dyy++O nbXumNHmvgxYvjFkWSC6TkfXUfyI1Hz7TyWJXSjmdKfsnOzJohYWSQtJ7tmuhZLc+0jm4WIgKmXxP OyFrwzg+Z5KiKvm+KzDm2gBdsOQWACgpeOvdat55QNeNc0mQQ7hd8891tOyBBKW77DFkTG3XMKGkV fKLPvwlvAMSPzSEw0vvIfMo2a5j3pbvDjUd0/yNtcvcZFO3TxV/afon1M/7pt84DkJsF5N+5UIf+0 cN6J5VLXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l49bM-00041R-2R; Mon, 25 Jan 2021 21:40:48 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l49bJ-00040r-SD for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 21:40:46 +0000 Received: by mail-ot1-f46.google.com with SMTP id n42so14270147ota.12 for ; Mon, 25 Jan 2021 13:40:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jFvGGF+GApXU3mEuRZRMts4wWuIR4lLZDNcLcWjS4Os=; b=RtUrf2GJS9ur0tjkZ5GA+3f4v7E+ZBqVxgFInUr1sWFaXK81/yjm2pPQZDwyZlfQsb 9TIMsQEc7ceBguyD1fAOAoddr3j/ZJrxNeT4zCeXqoaj7RD5kFnENZaGom6sm+kIcav6 8846o++8JjRNlFpUTj6nuGtZZho2B4nzUjNPL+RGU5tc1nsS40oB5gMz7fMliWv2ERyO hWII4PzlXyI7zk3jUrXNr6gX0doWVblNvsEy09eEQC0Yc3tiCFVFeg7Bd6y4UsBuq/bS otU0ZK/T4C+xL7CM5u7k//B6mg6kPAyMSJomDaph1pyJ6s9idIiOaWYfEpAf4/vkYU77 Wh+A== X-Gm-Message-State: AOAM533s0bel2OdSfMS5l+9gb0Y2UOkHupb+d1hWc9mpy7FULWSQ8q4S uVxhaynFLBkanngSppNAm9n1nltEdw== X-Google-Smtp-Source: ABdhPJzZDgcSoRHUG+fj06W9B8eAhd0yh8E5shntkS8AUWYZc/Zr9QKzD38zD0jd0vq74wHnVHC4iA== X-Received: by 2002:a05:6830:1589:: with SMTP id i9mr1772550otr.127.1611610844768; Mon, 25 Jan 2021 13:40:44 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t65sm3726614oie.25.2021.01.25.13.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 13:40:43 -0800 (PST) Received: (nullmailer pid 1053015 invoked by uid 1000); Mon, 25 Jan 2021 21:40:42 -0000 Date: Mon, 25 Jan 2021 15:40:42 -0600 From: Rob Herring To: Amelie Delaunay Subject: Re: [PATCH v2 1/2] dt-bindings: phy: phy-stm32-usbphyc: add #clock-cells required property Message-ID: <20210125214042.GA1049362@robh.at.kernel.org> References: <20210114171314.18946-1-amelie.delaunay@foss.st.com> <20210114171314.18946-2-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210114171314.18946-2-amelie.delaunay@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_164045_931792_00010109 X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Torgue , Vinod Koul , Maxime Coquelin , Kishon Vijay Abraham I , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 06:13:13PM +0100, Amelie Delaunay wrote: > usbphyc provides a unique clock called ck_usbo_48m. > STM32 USB OTG needs a 48Mhz clock (utmifs_clk48) for Full-Speed operation. > ck_usbo_48m is a possible parent clock for USB OTG 48Mhz clock. > > ck_usbo_48m is available as soon as the PLL is enabled. > > Signed-off-by: Amelie Delaunay > --- > No change in v2. > --- > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > index 46df6786727a..4e4da64b8e01 100644 > --- a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > @@ -51,6 +51,10 @@ properties: > vdda1v8-supply: > description: regulator providing 1V8 power supply to the PLL block > > + '#clock-cells': > + description: number of clock cells for ck_usbo_48m consumer > + const: 0 > + > #Required child nodes: > > patternProperties: > @@ -102,6 +106,7 @@ required: > - "#size-cells" > - vdda1v1-supply > - vdda1v8-supply > + - '#clock-cells' You can't really make new properties required as it's not backwards compatible. If things can never work without or the binding has never been used, then you can. You just need to spell this out in the commit msg. > - usb-phy@0 > - usb-phy@1 > > @@ -120,6 +125,7 @@ examples: > vdda1v8-supply = <®18>; > #address-cells = <1>; > #size-cells = <0>; > + #clock-cells = <0>; > > usbphyc_port0: usb-phy@0 { > reg = <0>; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D348EC433DB for ; Mon, 25 Jan 2021 21:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 987ED2083E for ; Mon, 25 Jan 2021 21:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733067AbhAYVl7 (ORCPT ); Mon, 25 Jan 2021 16:41:59 -0500 Received: from mail-ot1-f48.google.com ([209.85.210.48]:40577 "EHLO mail-ot1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732885AbhAYVlZ (ORCPT ); Mon, 25 Jan 2021 16:41:25 -0500 Received: by mail-ot1-f48.google.com with SMTP id i20so14294325otl.7; Mon, 25 Jan 2021 13:41:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jFvGGF+GApXU3mEuRZRMts4wWuIR4lLZDNcLcWjS4Os=; b=eVxweh7NTtj1/fKXW4BOPet3i5InnQlEvt1aUGGbFRWPd7Ce5TeymPQXju8jUL1jFU AsRR+TK16HA9xVibGZ0oaagDFp4xqFcRo/AvbSrDqb1mVbz6B1hOJdKLk7XTbkkB2zIb RGiza9b8wARo+If5RId0iAv8ogYxDfAR4YII6EUlZlB4Zrn2/ul85g60zkHcCwV231Bn BQ0xo425Dbm/t/zhGKgnDBTqlQNpkRej1/+t/TnvpZwD3Gxnnw1MTI3dmEhxVYay+mBy qiqpkI0gWke/S6u95/u6A2UcyDmr2D59G57mmF22OwjVUBRg3/wqCPgLXRAXheBuILOx tW9Q== X-Gm-Message-State: AOAM530XpzeTA4yfRYwj8Nyj8w5w+KJ5zD44Xv2ljTwv7fSxMzGhivwU 4/evg/YhFMW4NIcNxr4EEQ== X-Google-Smtp-Source: ABdhPJzZDgcSoRHUG+fj06W9B8eAhd0yh8E5shntkS8AUWYZc/Zr9QKzD38zD0jd0vq74wHnVHC4iA== X-Received: by 2002:a05:6830:1589:: with SMTP id i9mr1772550otr.127.1611610844768; Mon, 25 Jan 2021 13:40:44 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t65sm3726614oie.25.2021.01.25.13.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 13:40:43 -0800 (PST) Received: (nullmailer pid 1053015 invoked by uid 1000); Mon, 25 Jan 2021 21:40:42 -0000 Date: Mon, 25 Jan 2021 15:40:42 -0600 From: Rob Herring To: Amelie Delaunay Cc: Kishon Vijay Abraham I , Vinod Koul , Alexandre Torgue , Maxime Coquelin , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 1/2] dt-bindings: phy: phy-stm32-usbphyc: add #clock-cells required property Message-ID: <20210125214042.GA1049362@robh.at.kernel.org> References: <20210114171314.18946-1-amelie.delaunay@foss.st.com> <20210114171314.18946-2-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114171314.18946-2-amelie.delaunay@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 14, 2021 at 06:13:13PM +0100, Amelie Delaunay wrote: > usbphyc provides a unique clock called ck_usbo_48m. > STM32 USB OTG needs a 48Mhz clock (utmifs_clk48) for Full-Speed operation. > ck_usbo_48m is a possible parent clock for USB OTG 48Mhz clock. > > ck_usbo_48m is available as soon as the PLL is enabled. > > Signed-off-by: Amelie Delaunay > --- > No change in v2. > --- > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > index 46df6786727a..4e4da64b8e01 100644 > --- a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml > @@ -51,6 +51,10 @@ properties: > vdda1v8-supply: > description: regulator providing 1V8 power supply to the PLL block > > + '#clock-cells': > + description: number of clock cells for ck_usbo_48m consumer > + const: 0 > + > #Required child nodes: > > patternProperties: > @@ -102,6 +106,7 @@ required: > - "#size-cells" > - vdda1v1-supply > - vdda1v8-supply > + - '#clock-cells' You can't really make new properties required as it's not backwards compatible. If things can never work without or the binding has never been used, then you can. You just need to spell this out in the commit msg. > - usb-phy@0 > - usb-phy@1 > > @@ -120,6 +125,7 @@ examples: > vdda1v8-supply = <®18>; > #address-cells = <1>; > #size-cells = <0>; > + #clock-cells = <0>; > > usbphyc_port0: usb-phy@0 { > reg = <0>; > -- > 2.17.1 >