All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE
Date: Mon, 25 Jan 2021 17:22:03 -0500	[thread overview]
Message-ID: <20210125222203.GQ7530@bill-the-cat> (raw)
In-Reply-To: <3311137a-ce03-639e-7533-2633bf344d44@gmx.de>

On Mon, Jan 25, 2021 at 11:18:04PM +0100, Heinrich Schuchardt wrote:
> On 1/25/21 10:02 PM, Tom Rini wrote:
> > On Mon, Jan 25, 2021 at 05:28:39PM +0100, Heinrich Schuchardt wrote:
> > 
> > > Partitions are only relevant for block devices.
> > > 
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > ---
> > > I still need to check if the part command is needed on boards
> > > w/o DISTRO_DEFAULTS.
> > > ---
> > >   cmd/Kconfig  | 4 ++--
> > >   disk/Kconfig | 1 +
> > >   2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > So, https://gist.github.com/trini/806edc6d37b0e53931a3b8195cbf9da2 shows
> > all of the boards that had been building with this now invalid
> > combination and are discarding a bunch of code.  The next step is to
> > look at these and see which of them likely have a use case not been
> > described by these Kconfig choices.
> 
> With the patch for boards not using distro_defaults the following
> configuration items are dropped:
> 
> CONFIG_CMD_PART=y
> CONFIG_PARTITION_UUIDS=y
> 
> I will try to minimize the configuration changes produced by the next
> version of the patch.

OK, but my expectation is that there's either zero change in sizes OR
the board maintainer for those that do drop code agree it was
functionally useless code today.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210125/1b836380/attachment.sig>

      reply	other threads:[~2021-01-25 22:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 16:28 [RFC 1/1] disk: PARTITIONS should depend on HAVE_BLOCK_DEVICE Heinrich Schuchardt
2021-01-25 21:02 ` Tom Rini
2021-01-25 22:18   ` Heinrich Schuchardt
2021-01-25 22:22     ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125222203.GQ7530@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.