From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH linux-platform-drivers-x86] platform/x86: thinkpad_acpi: keyboard_lang_data[] can be static
Date: Tue, 26 Jan 2021 10:47:14 +0800 [thread overview]
Message-ID: <20210126024713.GA56241@dba771b738ee> (raw)
In-Reply-To: <202101261014.gblyDi4e-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
Fixes: d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 81f8ad6bb6886..85383b943a133 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9996,7 +9996,7 @@ struct keyboard_lang_data {
* When adding new entries to keyboard_lang_data, please check that
* the select_lang[] buffer in keyboard_lang_show() is still large enough.
*/
-struct keyboard_lang_data keyboard_lang_data[] = {
+static struct keyboard_lang_data keyboard_lang_data[] = {
{"en", 0},
{"be", 0x080c},
{"cz", 0x0405},
prev parent reply other threads:[~2021-01-26 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 2:47 [linux-platform-drivers-x86:review-hans 37/37] drivers/platform/x86/thinkpad_acpi.c:9999:27: sparse: sparse: symbol 'keyboard_lang_data' was not declared. Should it be kernel test robot
2021-01-26 2:47 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126024713.GA56241@dba771b738ee \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.