From: Jeff LaBundy <jeff@labundy.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 04/10] input: iqs5xx: Expose firmware revision to user space
Date: Mon, 25 Jan 2021 20:54:55 -0600 [thread overview]
Message-ID: <20210126025455.GA6155@labundy.com> (raw)
In-Reply-To: <YA5HaeHha1fTXARp@google.com>
Hi Dmitry,
Thank you for taking a look at this series and I do apologize for the
complaint from the bot this morning.
On Sun, Jan 24, 2021 at 08:22:01PM -0800, Dmitry Torokhov wrote:
> Hi Jeff,
>
> On Mon, Jan 18, 2021 at 02:43:40PM -0600, Jeff LaBundy wrote:
> > The device's firmware accommodates a revision field that customers
> > can assign when firmware is exported from the vendor's development
> > tool. Having the ability to read this field from user space can be
> > useful during development.
> >
> > As such, promote the fw_file attribute from W/O to R/W. Writing to
> > the attribute pushes firmware to the device as normal, but reading
> > from it will now return the customer-assigned revision field as an
> > unsigned integer (e.g. 256 = 1.0, 257 = 1.1 and so on).
>
> No, let's not overload this attribute and instead create a dedicated
> fw_version or similar read-only attribute to expose active firmware
> version to userspace.
Not a problem; I'll create a new R/O attribute for this purpose.
>
> Thanks.
>
> --
> Dmitry
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2021-01-26 19:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:43 [PATCH 00/10] input: iqs5xx: Minor enhancements and optimizations Jeff LaBundy
2021-01-18 20:43 ` [PATCH 01/10] input: iqs5xx: Minor cosmetic improvements Jeff LaBundy
2021-01-25 4:16 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 02/10] input: iqs5xx: Preserve bootloader errors Jeff LaBundy
2021-01-25 4:16 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 03/10] input: iqs5xx: Accommodate bootloader latency Jeff LaBundy
2021-01-25 4:19 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 04/10] input: iqs5xx: Expose firmware revision to user space Jeff LaBundy
2021-01-25 4:22 ` Dmitry Torokhov
2021-01-26 2:54 ` Jeff LaBundy [this message]
2021-01-18 20:43 ` [PATCH 05/10] input: iqs5xx: Re-initialize device upon warm reset Jeff LaBundy
2021-01-25 4:32 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 06/10] input: iqs5xx: Simplify axis setup logic Jeff LaBundy
2021-01-25 4:40 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 07/10] input: iqs5xx: Eliminate unnecessary register read Jeff LaBundy
2021-01-25 4:41 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 08/10] input: iqs5xx: Allow more time for ATI to complete Jeff LaBundy
2021-01-25 4:41 ` Dmitry Torokhov
2021-01-18 20:43 ` [PATCH 09/10] input: iqs5xx: Make reset GPIO optional Jeff LaBundy
2021-01-25 4:43 ` Dmitry Torokhov
2021-01-26 3:10 ` Jeff LaBundy
2021-01-18 20:43 ` [PATCH 10/10] input: iqs5xx: Allow device to be a wake-up source Jeff LaBundy
2021-01-25 4:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126025455.GA6155@labundy.com \
--to=jeff@labundy.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.