From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 26 Jan 2021 07:34:18 +0000 Subject: Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources() Message-Id: <20210126073418.GV2696@kadam> List-Id: References: <4D85574F-E711-46F8-A517-900F6D18954D@vmware.com> In-Reply-To: <4D85574F-E711-46F8-A517-900F6D18954D@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Zack Rusin Cc: David Airlie , "kernel-janitors@vger.kernel.org" , Roland Scheidegger , "dri-devel@lists.freedesktop.org" , Martin Krastev , Linux-graphics-maintainer On Mon, Jan 25, 2021 at 07:13:43PM +0000, Zack Rusin wrote: > > > > On Jan 25, 2021, at 03:45, Dan Carpenter wrote: > > > > The devm_memremap() function never returns NULL, it returns error > > pointers so the test needs to be fixed. Also we need to call > > pci_release_regions() to avoid a memory leak. > > > > Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") > > Signed-off-by: Dan Carpenter > > Thanks, Dan. > > I have a patch based on your report that fixes that too but it comes with a refactoring. I’d be happy to rebase it on top of yours just to get yours in before. If you’d like I can push your patch through drm-misc-next, if not: No no. Sorry, just apply your patch and drop mine. The problem is that the report I sent was from kbuild and I do my devel work on a different system so it's harder to track those emails and I forgot. Looking at it now, the bug report I sent earlier was only for the pci_release_regions() and not the NULL vs error pointer. The kbuild bot is not using full cross function analysis so it can't find those bugs. My dev system does much slower builds so it's a tradeoff. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69457C433E0 for ; Tue, 26 Jan 2021 07:34:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22DC62251D for ; Tue, 26 Jan 2021 07:34:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22DC62251D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49C556E416; Tue, 26 Jan 2021 07:34:43 +0000 (UTC) Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B7A26E416 for ; Tue, 26 Jan 2021 07:34:41 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10Q7TBgA155675; Tue, 26 Jan 2021 07:34:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2020-01-29; bh=Ey8PIiiwWn2CVbGpR1CyBjW7yu08hAySgOwNeW7M9is=; b=a/puMAySFBpMquWCdLC6Q7QrcPJrSfx8VVF9ORUd5NVXKCszCQZxr9GlknTUDuik8yqz ccotepwSg4Vr+BJUf8gGcE3SfunRxhtdS6swW5XuY40olQ5aUl8fDVwtLK2a2wzrUqxe MQe99tyI1Q9g5yggkIHf3w8L92X+UOhF63yYQMAZb3Vd3s/7sPVan50vT1xD1s/FFX8r q5sVpv9LIT2d1VTMOc6qnw/aE2TUXlCDemAx2tACDQAarkbY8eeCwQbdFdKCPepkBFTp XmHaoFxMrZaNvCb44SHPC1QPjZ+SutPlBua2Vkgg6UUtrLcnhTyoA2B/JIHq4Lk2MgcX hg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 3689aagyc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 07:34:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10Q7V2ao043381; Tue, 26 Jan 2021 07:34:35 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 368wcmkujb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 07:34:35 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 10Q7YRcu030844; Tue, 26 Jan 2021 07:34:28 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 Jan 2021 23:34:27 -0800 Date: Tue, 26 Jan 2021 10:34:18 +0300 From: Dan Carpenter To: Zack Rusin Subject: Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources() Message-ID: <20210126073418.GV2696@kadam> References: <4D85574F-E711-46F8-A517-900F6D18954D@vmware.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4D85574F-E711-46F8-A517-900F6D18954D@vmware.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9875 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260038 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9875 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260038 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "kernel-janitors@vger.kernel.org" , Roland Scheidegger , "dri-devel@lists.freedesktop.org" , Martin Krastev , Linux-graphics-maintainer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBKYW4gMjUsIDIwMjEgYXQgMDc6MTM6NDNQTSArMDAwMCwgWmFjayBSdXNpbiB3cm90 ZToKPiAKPiAKPiA+IE9uIEphbiAyNSwgMjAyMSwgYXQgMDM6NDUsIERhbiBDYXJwZW50ZXIgPGRh bi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4gd3JvdGU6Cj4gPiAKPiA+IFRoZSBkZXZtX21lbXJlbWFw KCkgZnVuY3Rpb24gbmV2ZXIgcmV0dXJucyBOVUxMLCBpdCByZXR1cm5zIGVycm9yCj4gPiBwb2lu dGVycyBzbyB0aGUgdGVzdCBuZWVkcyB0byBiZSBmaXhlZC4gIEFsc28gd2UgbmVlZCB0byBjYWxs Cj4gPiBwY2lfcmVsZWFzZV9yZWdpb25zKCkgdG8gYXZvaWQgYSBtZW1vcnkgbGVhay4KPiA+IAo+ ID4gRml4ZXM6IGJlNGY3N2FjNjg4NCAoImRybS92bXdnZng6IENsZWFudXAgZmlmbyBtbWlvIGhh bmRsaW5nIikKPiA+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJA b3JhY2xlLmNvbT4KPiAKPiBUaGFua3MsIERhbi4KPiAKPiBJIGhhdmUgYSBwYXRjaCBiYXNlZCBv biB5b3VyIHJlcG9ydCB0aGF0IGZpeGVzIHRoYXQgdG9vIGJ1dCBpdCBjb21lcyB3aXRoIGEgcmVm YWN0b3JpbmcuIEnigJlkIGJlIGhhcHB5IHRvIHJlYmFzZSBpdCBvbiB0b3Agb2YgeW91cnMganVz dCB0byBnZXQgeW91cnMgaW4gYmVmb3JlLiBJZiB5b3XigJlkIGxpa2UgSSBjYW4gcHVzaCB5b3Vy IHBhdGNoIHRocm91Z2ggZHJtLW1pc2MtbmV4dCwgaWYgbm90OgoKCk5vIG5vLiAgU29ycnksIGp1 c3QgYXBwbHkgeW91ciBwYXRjaCBhbmQgZHJvcCBtaW5lLiAgVGhlIHByb2JsZW0gaXMgdGhhdAp0 aGUgcmVwb3J0IEkgc2VudCB3YXMgZnJvbSBrYnVpbGQgYW5kIEkgZG8gbXkgZGV2ZWwgd29yayBv biBhIGRpZmZlcmVudApzeXN0ZW0gc28gaXQncyBoYXJkZXIgdG8gdHJhY2sgdGhvc2UgZW1haWxz IGFuZCBJIGZvcmdvdC4KCkxvb2tpbmcgYXQgaXQgbm93LCB0aGUgYnVnIHJlcG9ydCBJIHNlbnQg ZWFybGllciB3YXMgb25seSBmb3IgdGhlCnBjaV9yZWxlYXNlX3JlZ2lvbnMoKSBhbmQgbm90IHRo ZSBOVUxMIHZzIGVycm9yIHBvaW50ZXIuICBUaGUga2J1aWxkCmJvdCBpcyBub3QgdXNpbmcgZnVs bCBjcm9zcyBmdW5jdGlvbiBhbmFseXNpcyBzbyBpdCBjYW4ndCBmaW5kIHRob3NlCmJ1Z3MuICBN eSBkZXYgc3lzdGVtIGRvZXMgbXVjaCBzbG93ZXIgYnVpbGRzIHNvIGl0J3MgYSB0cmFkZW9mZi4K CnJlZ2FyZHMsCmRhbiBjYXJwZW50ZXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=