From: Florian Westphal <fw@strlen.de>
To: Andreas Schultz <andreas.schultz@travelping.com>
Cc: netfilter <netfilter@vger.kernel.org>
Subject: Re: parser problem in range map?
Date: Tue, 26 Jan 2021 16:32:06 +0100 [thread overview]
Message-ID: <20210126153206.GT19605@breakpoint.cc> (raw)
In-Reply-To: <CAC=ZbaS3H09px4EfJQx5gaWv9zthVxD3LQHjue9vfsjcfG_zOw@mail.gmail.com>
Andreas Schultz <andreas.schultz@travelping.com> wrote:
> The following simple ruleset fails to load on nftables 0.9.8 (from
> Ubuntu 21.04):
>
> #!/usr/sbin/nft -f
>
> flush ruleset
>
> table inet nat {
> chain prerouting {
> type filter hook prerouting priority -100;
> ip daddr set numgen inc mod 16 map { 0 - 7 : 10.0.1.1, 8 - 15
> : 10.0.1.2 }
> }
>
> chain postrouting {
> type filter hook postrouting priority 100;
> }
> }
>
> It throws this error:
>
> # nft -f test.nft
> test.nft:12:40-42: Error: Value 100 exceeds valid range 0-15
> type filter hook postrouting priority 100;
> ^^^
> test.nft:12:31-42: Error: invalid priority expression value in this context.
> type filter hook postrouting priority 100;
> ^^^^^^^^^^^^
>
> Is there something wrong with my expression or is this a bug?
Bug. This looks like the right fix:
diff --git a/src/evaluate.c b/src/evaluate.c
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -3789,8 +3789,8 @@ static bool evaluate_priority(struct eval_ctx *ctx, struct prio_spec *prio,
int prio_snd;
char op;
- ctx->ectx.dtype = &priority_type;
- ctx->ectx.len = NFT_NAME_MAXLEN * BITS_PER_BYTE;
+ expr_set_context(&ctx->ectx, &priority_type, NFT_NAME_MAXLEN * BITS_PER_BYTE);
+
if (expr_evaluate(ctx, &prio->expr) < 0)
return false;
prev parent reply other threads:[~2021-01-26 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 15:02 parser problem in range map? Andreas Schultz
2021-01-26 15:32 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126153206.GT19605@breakpoint.cc \
--to=fw@strlen.de \
--cc=andreas.schultz@travelping.com \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.