From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95019C433DB for ; Tue, 26 Jan 2021 16:38:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4072722241 for ; Tue, 26 Jan 2021 16:38:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4072722241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kr34wWmck9DMOjyGsj1GkTBBbjddK/kw0+Th0QhNJng=; b=P8C6NMaF7zXMm/fdl9jnOO2qf OuVsRVUtaO2lgS130A4rxfQHdx2ONi27V62rUBbPKwtPUpZG8SZzBQJnalcuLGp1Aloa5QRj5zhou NRbNjr+IqXaZBSbkJdBdXRNi7mINpOxEGBE0oyv+jCa7ioSn0mJf7z2/yXbXwPSh5IDqpHvtu9ZgY dz4RWDWapgC2SMimB8ZV1nzoaq5OQYW57PErdsGiOmqMNfuRgDtDbQCAF2nsY35cjo9FuVJ/Ci80+ iBOzLQ8OXz+/2SCGdF1z8AQ1MpEBM50tolfZIpnix7Vz/YZqExmoy47bcvgStkdHGnGh4VjDRMRT6 SLgvUWIsQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4RKg-0002LD-Sz; Tue, 26 Jan 2021 16:36:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4RKe-0002KJ-JH for linux-arm-kernel@lists.infradead.org; Tue, 26 Jan 2021 16:36:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A940C22241; Tue, 26 Jan 2021 16:36:41 +0000 (UTC) Date: Tue, 26 Jan 2021 16:36:39 +0000 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH] arm64: Fix kernel address detection of __is_lm_address() Message-ID: <20210126163638.GA3509@gaia> References: <20210126134056.45747-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210126134056.45747-1-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210126_113644_707738_9BD2791D X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kasan-dev@googlegroups.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 26, 2021 at 01:40:56PM +0000, Vincenzo Frascino wrote: > Currently, the __is_lm_address() check just masks out the top 12 bits > of the address, but if they are 0, it still yields a true result. > This has as a side effect that virt_addr_valid() returns true even for > invalid virtual addresses (e.g. 0x0). > > Fix the detection checking that it's actually a kernel address starting > at PAGE_OFFSET. > > Fixes: f4693c2716b35 ("arm64: mm: extend linear region for 52-bit VA configurations") > Cc: # 5.4.x Not sure what happened with the Fixes tag but that's definitely not what it fixes. The above is a 5.11 commit that preserves the semantics of an older commit. So it should be: Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()") The above also had a fix for another commit but no need to add two entries, we just fix the original fix: 14c127c957c1 ("arm64: mm: Flip kernel VA space"). Anyway, no need to repost, I can update the fixes tag myself. In terms of stable backports, it may be cleaner to backport 7bc1a0f9e176 ("arm64: mm: use single quantity to represent the PA to VA translation") which has a Fixes tag already but never made it to -stable. On top of this, we can backport Ard's latest f4693c2716b35 ("arm64: mm: extend linear region for 52-bit VA configurations"). I just tried these locally and the conflicts were fairly trivial. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8EAC433E6 for ; Tue, 26 Jan 2021 18:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45C4F20793 for ; Tue, 26 Jan 2021 18:10:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394095AbhAZSKL (ORCPT ); Tue, 26 Jan 2021 13:10:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:54752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389836AbhAZQhX (ORCPT ); Tue, 26 Jan 2021 11:37:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A940C22241; Tue, 26 Jan 2021 16:36:41 +0000 (UTC) Date: Tue, 26 Jan 2021 16:36:39 +0000 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, stable@vger.kernel.org, Will Deacon , Mark Rutland Subject: Re: [PATCH] arm64: Fix kernel address detection of __is_lm_address() Message-ID: <20210126163638.GA3509@gaia> References: <20210126134056.45747-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126134056.45747-1-vincenzo.frascino@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 01:40:56PM +0000, Vincenzo Frascino wrote: > Currently, the __is_lm_address() check just masks out the top 12 bits > of the address, but if they are 0, it still yields a true result. > This has as a side effect that virt_addr_valid() returns true even for > invalid virtual addresses (e.g. 0x0). > > Fix the detection checking that it's actually a kernel address starting > at PAGE_OFFSET. > > Fixes: f4693c2716b35 ("arm64: mm: extend linear region for 52-bit VA configurations") > Cc: # 5.4.x Not sure what happened with the Fixes tag but that's definitely not what it fixes. The above is a 5.11 commit that preserves the semantics of an older commit. So it should be: Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()") The above also had a fix for another commit but no need to add two entries, we just fix the original fix: 14c127c957c1 ("arm64: mm: Flip kernel VA space"). Anyway, no need to repost, I can update the fixes tag myself. In terms of stable backports, it may be cleaner to backport 7bc1a0f9e176 ("arm64: mm: use single quantity to represent the PA to VA translation") which has a Fixes tag already but never made it to -stable. On top of this, we can backport Ard's latest f4693c2716b35 ("arm64: mm: extend linear region for 52-bit VA configurations"). I just tried these locally and the conflicts were fairly trivial. -- Catalin