From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4E8C433DB for ; Wed, 27 Jan 2021 08:30:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B96C62074B for ; Wed, 27 Jan 2021 08:30:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B96C62074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AEDB6E7EA; Wed, 27 Jan 2021 08:29:52 +0000 (UTC) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by gabe.freedesktop.org (Postfix) with ESMTPS id AAB8189C84 for ; Tue, 26 Jan 2021 21:17:36 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id j13so21512378edp.2 for ; Tue, 26 Jan 2021 13:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nELwzlUlP6axkorz2djr4guRUf+IWYEa8K0PWf9nTOU=; b=MI5Yn4GQix/Onk1AXDBpkLu8gGJ0+ZJPmdZJTwQ+kS11QNftnWwldp71R0ffDbjgXX voO4MnYL/dzs58rhk5fBEN6adzDnXRGW837juTSJNruW7OZEYjPc56ZtRTEke1r4PyjX WSWvv66Vf2X++L3OgVDMtnMQ9x2VWL0J3B7pXqo4VRcb7bgBa7fZmEwWHNAKY6B4AEgU QHdEwNehuqYfA7crHzh5zAR6PtxMSWxg3tobFX8qm9djD6gaLWSrs0LPCjNfKgqmpGvT TcaLkqPqk3lwS7Nn4qEcNmoK8NpuXEjQUfMSwdwjQE0mHddJYwAyd+u9JbpZVuydv6WZ pWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nELwzlUlP6axkorz2djr4guRUf+IWYEa8K0PWf9nTOU=; b=G5zC9UAmwvRE2oskeyS7RprWl1lleCzd8kgRyeN5Evl5p0SuowuIVw95Kv5TIQodMA 474Z6mt/90ReTqeZyww4QeYdZL/heXtT/nnpFdUsfN3L8cCTOaT0ZCBDTQh204iCjbfw KrzWKQa1pIue2gUf3HvPoSlSkC4HaTURQ5/Ap9NH5ibV1YiJcMK75u+vv34apunn/Mn/ Mw3rhm1tcvU/7/u9nzKxIU3tG5cP4R/NlOD2P2XCMo19ihI0KaOCBC9ZwSceiwfmUosZ UpDkizQetFYDMTWTnPRkBIJfcyPxKsmflUQR4D/839C/haeGeqRSgTYMSX6iVvLHHXCk 7jnA== X-Gm-Message-State: AOAM530QHINX/YS43x5NOUKafJjBv4nnqN1xOp0BnIJhYmdF1wwp6OuL NVFJyvwUOg5DENKRlomVuaU= X-Google-Smtp-Source: ABdhPJy4wQRLKh/Cy7gtx3UaZtRIBsQTsVIk5N8CGxrOkT2rebKaO5+ZA7CUxEbx0O9LEX4QoSSfSg== X-Received: by 2002:a50:fe85:: with SMTP id d5mr6304033edt.140.1611695855329; Tue, 26 Jan 2021 13:17:35 -0800 (PST) Received: from localhost (ipv6-64fbc1442191a03a.ost.clients.hamburg.freifunk.net. [2a03:2267:4:0:64fb:c144:2191:a03a]) by smtp.gmail.com with ESMTPSA id p3sm13208836edh.50.2021.01.26.13.17.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jan 2021 13:17:34 -0800 (PST) Date: Tue, 26 Jan 2021 22:17:23 +0100 From: Oliver Graute To: Fabio Estevam Subject: Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD Message-ID: <20210126211723.GA17512@portage> References: <20210110153532.GA7264@ripley> <20210110200606.GD7264@ripley> <20210116124856.GA3406@portage> <20210125212917.GA4177@portage> <20210125221701.GA20107@ripley> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Approved-At: Wed, 27 Jan 2021 08:29:46 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Marco Felsch , DRI mailing list , linux-kernel , Thierry Reding , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 26/01/21, Fabio Estevam wrote: > Hi Oliver, > > On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute wrote: > > > I would prefer mine, because I got a wrong colored penguin on bootup > > with yours :-) The wrong colored Tux is caused by the bus_format: .bus_format = MEDIA_BUS_FMT_RGB888_1X24, So I assume I need another bus_format here. > > I have originally passed .bpc = 8, but looking at the panel datasheet, > this should be: > .bpc = 6 instead. yes this is right. I found it too in the datasheet. I'll fix it in next version of the patch. > > In your patch, you pass the timing parameters three times, but they > are all the same. > > Usually, it is meant to be: minimal, typical, maximum values. yes because on a lot of entries there is just the typical value and no min and max. But not on all of them. Best regards, Oliver _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE10C43381 for ; Wed, 27 Jan 2021 03:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04EBC2064B for ; Wed, 27 Jan 2021 03:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236296AbhA0Dd7 (ORCPT ); Tue, 26 Jan 2021 22:33:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729637AbhAZVUC (ORCPT ); Tue, 26 Jan 2021 16:20:02 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98A4CC0617A9 for ; Tue, 26 Jan 2021 13:17:36 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id s11so21502626edd.5 for ; Tue, 26 Jan 2021 13:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nELwzlUlP6axkorz2djr4guRUf+IWYEa8K0PWf9nTOU=; b=MI5Yn4GQix/Onk1AXDBpkLu8gGJ0+ZJPmdZJTwQ+kS11QNftnWwldp71R0ffDbjgXX voO4MnYL/dzs58rhk5fBEN6adzDnXRGW837juTSJNruW7OZEYjPc56ZtRTEke1r4PyjX WSWvv66Vf2X++L3OgVDMtnMQ9x2VWL0J3B7pXqo4VRcb7bgBa7fZmEwWHNAKY6B4AEgU QHdEwNehuqYfA7crHzh5zAR6PtxMSWxg3tobFX8qm9djD6gaLWSrs0LPCjNfKgqmpGvT TcaLkqPqk3lwS7Nn4qEcNmoK8NpuXEjQUfMSwdwjQE0mHddJYwAyd+u9JbpZVuydv6WZ pWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nELwzlUlP6axkorz2djr4guRUf+IWYEa8K0PWf9nTOU=; b=qjtqx4HHLBfFF/nYjiBx6+TxKM8KhK0eA+CMocLnIBRGr1Pd79Lh41NWjkHKCb76zW 02KExt1HE8xYaqbSDMRQ49x37b+glzYuz5qrZKpwQmyL1D/cTR4/Ct6JFxo52857YRlh NpQHSXESH0rP4VqzO/L+lBWZgT8x924Zz0pr+7vmjjfSqD7u1fKX7hoWC1splaD7kf2A MAqQ8dLvmj4NjTIxuFqtSZEjGMdh7c5+3BrxnIyPDtI6EFGklZ/7dJkRvDFEFFrdopYb HPvSL5/tKtWb71aMQM68DRcb1KUoh5+Po1kNoMQk3YuL/bFtvUhInYjgjRpKQigLffwN WArg== X-Gm-Message-State: AOAM530tKgKD5/IGY6BBx2hGv7kfzCE/LNxlPpWkswZLqemPopvCtY0K 7L/FLjkXLWeR/dDL2Z4R0ENQQp5CsU2a3Q== X-Google-Smtp-Source: ABdhPJy4wQRLKh/Cy7gtx3UaZtRIBsQTsVIk5N8CGxrOkT2rebKaO5+ZA7CUxEbx0O9LEX4QoSSfSg== X-Received: by 2002:a50:fe85:: with SMTP id d5mr6304033edt.140.1611695855329; Tue, 26 Jan 2021 13:17:35 -0800 (PST) Received: from localhost (ipv6-64fbc1442191a03a.ost.clients.hamburg.freifunk.net. [2a03:2267:4:0:64fb:c144:2191:a03a]) by smtp.gmail.com with ESMTPSA id p3sm13208836edh.50.2021.01.26.13.17.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jan 2021 13:17:34 -0800 (PST) Date: Tue, 26 Jan 2021 22:17:23 +0100 From: Oliver Graute To: Fabio Estevam Cc: Thierry Reding , Sam Ravnborg , Marco Felsch , David Airlie , Daniel Vetter , DRI mailing list , linux-kernel Subject: Re: [PATCH v1] drm/panel: simple: add SGD GKTW70SDAD1SD Message-ID: <20210126211723.GA17512@portage> References: <20210110153532.GA7264@ripley> <20210110200606.GD7264@ripley> <20210116124856.GA3406@portage> <20210125212917.GA4177@portage> <20210125221701.GA20107@ripley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/21, Fabio Estevam wrote: > Hi Oliver, > > On Mon, Jan 25, 2021 at 7:17 PM Oliver Graute wrote: > > > I would prefer mine, because I got a wrong colored penguin on bootup > > with yours :-) The wrong colored Tux is caused by the bus_format: .bus_format = MEDIA_BUS_FMT_RGB888_1X24, So I assume I need another bus_format here. > > I have originally passed .bpc = 8, but looking at the panel datasheet, > this should be: > .bpc = 6 instead. yes this is right. I found it too in the datasheet. I'll fix it in next version of the patch. > > In your patch, you pass the timing parameters three times, but they > are all the same. > > Usually, it is meant to be: minimal, typical, maximum values. yes because on a lot of entries there is just the typical value and no min and max. But not on all of them. Best regards, Oliver