From: Raju Rangoju <rajur@chelsio.com>
To: Yang Li <abaci-bugfix@linux.alibaba.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] cxgb4: remove redundant NULL check
Date: Wed, 27 Jan 2021 09:26:06 +0530 [thread overview]
Message-ID: <20210127035604.GA21071@chelsio.com> (raw)
In-Reply-To: <1611568045-121839-4-git-send-email-abaci-bugfix@linux.alibaba.com>
On Monday, January 01/25/21, 2021 at 17:47:25 +0800, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING:
> NULL check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> index dede025..97a811f 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> @@ -525,12 +525,10 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap)
> for (i = 0; i < t->size; i++) {
> struct cxgb4_link *link = &t->table[i];
>
> - if (link->tid_map)
> - kvfree(link->tid_map);
This patch is wrong. NAK.
What if the call to link->tid_map = kvcalloc() fails above? it still goes ahead
and calls kvfree(link->tid_map), which is wrong.
> + kvfree(link->tid_map);
> }
>
> - if (t)
> - kvfree(t);
> + kvfree(t);
>
> return NULL;
> }
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2021-01-27 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 9:47 [PATCH 1/4] cxgb4: remove redundant NULL check Yang Li
2021-01-25 9:47 ` [PATCH 2/4] " Yang Li
2021-01-25 9:47 ` [PATCH 3/4] " Yang Li
2021-01-27 4:05 ` Raju Rangoju
2021-01-25 9:47 ` [PATCH 4/4] " Yang Li
2021-01-27 3:56 ` Raju Rangoju [this message]
2021-01-25 21:14 ` [PATCH 1/4] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127035604.GA21071@chelsio.com \
--to=rajur@chelsio.com \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.