From: carlis <zhangxuezhi3@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, mh12gx2825@gmail.com,
oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sbrivio@redhat.com,
colin.king@canonical.com, zhangxuezhi1@yulong.com
Subject: Re: [PATCH v4] fbtft: add tearing signal detect
Date: Wed, 27 Jan 2021 09:15:49 +0800 [thread overview]
Message-ID: <20210127091549.00005933@gmail.com> (raw)
In-Reply-To: <20210126175141.GZ2696@kadam>
On Tue, 26 Jan 2021 20:51:41 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Jan 26, 2021 at 08:40:35PM +0800, Carlis wrote:
> > @@ -82,6 +111,29 @@ enum st7789v_command {
> > */
> > static int init_display(struct fbtft_par *par)
> > {
> > + int rc;
> > + struct device *dev = par->info->device;
> > +
> > + par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,
> > GPIOD_IN);
> > + if (par->gpio.te) {
>
> I explained in my earlier review that devm_gpiod_get_index_optional()
> can return error pointers... There was quite a bit of detail about
> how to handle this correctly in my earlier review, but I think you
> might not have noticed it. Please read it again.
>
> > + init_completion(&spi_panel_te);
> > + mutex_init(&te_mutex);
> > + rc = devm_request_irq(dev,
> > + gpiod_to_irq(par->gpio.te),
> > + spi_panel_te_handler,
> > IRQF_TRIGGER_RISING,
> > + "TE_GPIO", par);
> > + if (rc) {
> > + pr_err("TE request_irq failed.\n");
> > + devm_gpiod_put(dev, par->gpio.te);
> > + par->gpio.te = NULL;
> > + } else {
> > +
> > disable_irq_nosync(gpiod_to_irq(par->gpio.te));
> > + pr_info("TE request_irq completion.\n");
> > + }
> > + } else {
> > + pr_err("%s:%d, TE gpio not specified\n",
> > + __func__, __LINE__);
> > + }
>
> regards,
> dan carpenter
>
Thank you for your correction,i will change pr_err to pr_info in next
patch v5
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: carlis <zhangxuezhi3@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
mh12gx2825@gmail.com, gregkh@linuxfoundation.org,
oliver.graute@kococonnector.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sbrivio@redhat.com,
colin.king@canonical.com, zhangxuezhi1@yulong.com
Subject: Re: [PATCH v4] fbtft: add tearing signal detect
Date: Wed, 27 Jan 2021 09:15:49 +0800 [thread overview]
Message-ID: <20210127091549.00005933@gmail.com> (raw)
In-Reply-To: <20210126175141.GZ2696@kadam>
On Tue, 26 Jan 2021 20:51:41 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Jan 26, 2021 at 08:40:35PM +0800, Carlis wrote:
> > @@ -82,6 +111,29 @@ enum st7789v_command {
> > */
> > static int init_display(struct fbtft_par *par)
> > {
> > + int rc;
> > + struct device *dev = par->info->device;
> > +
> > + par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,
> > GPIOD_IN);
> > + if (par->gpio.te) {
>
> I explained in my earlier review that devm_gpiod_get_index_optional()
> can return error pointers... There was quite a bit of detail about
> how to handle this correctly in my earlier review, but I think you
> might not have noticed it. Please read it again.
>
> > + init_completion(&spi_panel_te);
> > + mutex_init(&te_mutex);
> > + rc = devm_request_irq(dev,
> > + gpiod_to_irq(par->gpio.te),
> > + spi_panel_te_handler,
> > IRQF_TRIGGER_RISING,
> > + "TE_GPIO", par);
> > + if (rc) {
> > + pr_err("TE request_irq failed.\n");
> > + devm_gpiod_put(dev, par->gpio.te);
> > + par->gpio.te = NULL;
> > + } else {
> > +
> > disable_irq_nosync(gpiod_to_irq(par->gpio.te));
> > + pr_info("TE request_irq completion.\n");
> > + }
> > + } else {
> > + pr_err("%s:%d, TE gpio not specified\n",
> > + __func__, __LINE__);
> > + }
>
> regards,
> dan carpenter
>
Thank you for your correction,i will change pr_err to pr_info in next
patch v5
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-27 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:40 [PATCH v4] fbtft: add tearing signal detect Carlis
2021-01-26 12:40 ` Carlis
2021-01-26 17:51 ` Dan Carpenter
2021-01-26 17:51 ` Dan Carpenter
2021-01-27 1:15 ` carlis [this message]
2021-01-27 1:15 ` carlis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127091549.00005933@gmail.com \
--to=zhangxuezhi3@gmail.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=oliver.graute@kococonnector.com \
--cc=sbrivio@redhat.com \
--cc=zhangxuezhi1@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.