From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 142A0C433DB for ; Wed, 27 Jan 2021 11:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB3CB2076D for ; Wed, 27 Jan 2021 11:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237236AbhA0LyY (ORCPT ); Wed, 27 Jan 2021 06:54:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:60598 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237395AbhA0LwM (ORCPT ); Wed, 27 Jan 2021 06:52:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D5784ABDA; Wed, 27 Jan 2021 11:51:30 +0000 (UTC) Date: Wed, 27 Jan 2021 12:51:27 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , Thomas Gleixner , "Peter Zijlstra (Intel)" , Mike Rapoport , Michal Hocko , Wei Yang Subject: Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page() Message-ID: <20210127115122.GA28728@linux> References: <20210126182113.19892-1-david@redhat.com> <20210126182113.19892-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126182113.19892-3-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote: > adjust_managed_page_count() as called by free_reserved_page() properly > handles pages in a highmem zone, so we can reuse it for > free_highmem_page(). > > We can now get rid of totalhigh_pages_inc() and simplify > free_reserved_page(). > > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: "Peter Zijlstra (Intel)" > Cc: Mike Rapoport > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > +#define free_highmem_page(page) free_reserved_page(page) Should we place that under #ifdef CONFIG_HIGHMEM to make clear that it is only used on that config? Maybe the #ifdefery ugliness does not pay off. -- Oscar Salvador SUSE L3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124BDC433E0 for ; Thu, 28 Jan 2021 08:17:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B12B96146D for ; Thu, 28 Jan 2021 08:17:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B12B96146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF49A6E92E; Thu, 28 Jan 2021 08:16:48 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C8C06E039 for ; Wed, 27 Jan 2021 11:51:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D5784ABDA; Wed, 27 Jan 2021 11:51:30 +0000 (UTC) Date: Wed, 27 Jan 2021 12:51:27 +0100 From: Oscar Salvador To: David Hildenbrand Subject: Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page() Message-ID: <20210127115122.GA28728@linux> References: <20210126182113.19892-1-david@redhat.com> <20210126182113.19892-3-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210126182113.19892-3-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Thu, 28 Jan 2021 08:15:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Wei Yang , "Peter Zijlstra \(Intel\)" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Andrew Morton , Thomas Gleixner , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote: > adjust_managed_page_count() as called by free_reserved_page() properly > handles pages in a highmem zone, so we can reuse it for > free_highmem_page(). > > We can now get rid of totalhigh_pages_inc() and simplify > free_reserved_page(). > > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: "Peter Zijlstra (Intel)" > Cc: Mike Rapoport > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > +#define free_highmem_page(page) free_reserved_page(page) Should we place that under #ifdef CONFIG_HIGHMEM to make clear that it is only used on that config? Maybe the #ifdefery ugliness does not pay off. -- Oscar Salvador SUSE L3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel