From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2CEC433DB for ; Wed, 27 Jan 2021 11:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A9A020773 for ; Wed, 27 Jan 2021 11:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234464AbhA0L7M (ORCPT ); Wed, 27 Jan 2021 06:59:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:33416 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237239AbhA0Ly0 (ORCPT ); Wed, 27 Jan 2021 06:54:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 684A9ACBA; Wed, 27 Jan 2021 11:53:44 +0000 (UTC) Date: Wed, 27 Jan 2021 12:53:41 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , Thomas Gleixner , "Peter Zijlstra (Intel)" , Mike Rapoport , Michal Hocko , Wei Yang , "Gustavo A. R. Silva" , Sam Ravnborg Subject: Re: [PATCH v1 1/2] video: fbdev: acornfb: remove free_unused_pages() Message-ID: <20210127115341.GB28728@linux> References: <20210126182113.19892-1-david@redhat.com> <20210126182113.19892-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126182113.19892-2-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, Jan 26, 2021 at 07:21:12PM +0100, David Hildenbrand wrote: > This function is never used and it is one of the last remaining user of > __free_reserved_page(). Let's just drop it. > > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: "Peter Zijlstra (Intel)" > Cc: Mike Rapoport > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Cc: "Gustavo A. R. Silva" > Cc: Sam Ravnborg > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > --- > drivers/video/fbdev/acornfb.c | 34 ---------------------------------- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c > index bcc92aecf666..1b72edc01cfb 100644 > --- a/drivers/video/fbdev/acornfb.c > +++ b/drivers/video/fbdev/acornfb.c > @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) > return 4; > } > > -/* > - * This enables the unused memory to be freed on older Acorn machines. > - * We are freeing memory on behalf of the architecture initialisation > - * code here. > - */ > -static inline void > -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end) > -{ > - int mb_freed = 0; > - > - /* > - * Align addresses > - */ > - virtual_start = PAGE_ALIGN(virtual_start); > - virtual_end = PAGE_ALIGN(virtual_end); > - > - while (virtual_start < virtual_end) { > - struct page *page; > - > - /* > - * Clear page reserved bit, > - * set count to 1, and free > - * the page. > - */ > - page = virt_to_page(virtual_start); > - __free_reserved_page(page); > - > - virtual_start += PAGE_SIZE; > - mb_freed += PAGE_SIZE / 1024; > - } > - > - printk("acornfb: freed %dK memory\n", mb_freed); > -} > - > static int acornfb_probe(struct platform_device *dev) > { > unsigned long size; > -- > 2.29.2 > -- Oscar Salvador SUSE L3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D70EC433E6 for ; Thu, 28 Jan 2021 08:17:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5F1C64DD1 for ; Thu, 28 Jan 2021 08:17:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F1C64DD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF5E76E924; Thu, 28 Jan 2021 08:16:47 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFE2C89850 for ; Wed, 27 Jan 2021 11:53:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 684A9ACBA; Wed, 27 Jan 2021 11:53:44 +0000 (UTC) Date: Wed, 27 Jan 2021 12:53:41 +0100 From: Oscar Salvador To: David Hildenbrand Subject: Re: [PATCH v1 1/2] video: fbdev: acornfb: remove free_unused_pages() Message-ID: <20210127115341.GB28728@linux> References: <20210126182113.19892-1-david@redhat.com> <20210126182113.19892-2-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210126182113.19892-2-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Thu, 28 Jan 2021 08:15:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, "Gustavo A. R. Silva" , Wei Yang , "Peter Zijlstra \(Intel\)" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, Andrew Morton , Sam Ravnborg , Thomas Gleixner , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 26, 2021 at 07:21:12PM +0100, David Hildenbrand wrote: > This function is never used and it is one of the last remaining user of > __free_reserved_page(). Let's just drop it. > > Cc: Andrew Morton > Cc: Thomas Gleixner > Cc: "Peter Zijlstra (Intel)" > Cc: Mike Rapoport > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Wei Yang > Cc: "Gustavo A. R. Silva" > Cc: Sam Ravnborg > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > --- > drivers/video/fbdev/acornfb.c | 34 ---------------------------------- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/video/fbdev/acornfb.c b/drivers/video/fbdev/acornfb.c > index bcc92aecf666..1b72edc01cfb 100644 > --- a/drivers/video/fbdev/acornfb.c > +++ b/drivers/video/fbdev/acornfb.c > @@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) > return 4; > } > > -/* > - * This enables the unused memory to be freed on older Acorn machines. > - * We are freeing memory on behalf of the architecture initialisation > - * code here. > - */ > -static inline void > -free_unused_pages(unsigned int virtual_start, unsigned int virtual_end) > -{ > - int mb_freed = 0; > - > - /* > - * Align addresses > - */ > - virtual_start = PAGE_ALIGN(virtual_start); > - virtual_end = PAGE_ALIGN(virtual_end); > - > - while (virtual_start < virtual_end) { > - struct page *page; > - > - /* > - * Clear page reserved bit, > - * set count to 1, and free > - * the page. > - */ > - page = virt_to_page(virtual_start); > - __free_reserved_page(page); > - > - virtual_start += PAGE_SIZE; > - mb_freed += PAGE_SIZE / 1024; > - } > - > - printk("acornfb: freed %dK memory\n", mb_freed); > -} > - > static int acornfb_probe(struct platform_device *dev) > { > unsigned long size; > -- > 2.29.2 > -- Oscar Salvador SUSE L3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel