From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4 8/8] drm/i915: allocate cmd ring in lmem
Date: Wed, 27 Jan 2021 12:48:09 +0000 [thread overview]
Message-ID: <20210127124809.384080-8-matthew.auld@intel.com> (raw)
In-Reply-To: <20210127124809.384080-1-matthew.auld@intel.com>
From: Michel Thierry <michel.thierry@intel.com>
Prefer allocating the cmd ring from LMEM on dgfx.
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_ring.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
index 29c87b3c23bc..aee0a77c77e0 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring.c
@@ -3,6 +3,7 @@
* Copyright © 2019 Intel Corporation
*/
+#include "gem/i915_gem_lmem.h"
#include "gem/i915_gem_object.h"
#include "i915_drv.h"
@@ -108,8 +109,8 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
struct drm_i915_gem_object *obj;
struct i915_vma *vma;
- obj = ERR_PTR(-ENODEV);
- if (i915_ggtt_has_aperture(ggtt))
+ obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_VOLATILE);
+ if (IS_ERR(obj) && i915_ggtt_has_aperture(ggtt))
obj = i915_gem_object_create_stolen(i915, size);
if (IS_ERR(obj))
obj = i915_gem_object_create_internal(i915, size);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-27 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 12:48 [Intel-gfx] [PATCH v4 1/8] drm/i915: make local-memory probing a GT operation Matthew Auld
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 2/8] drm/i915: setup the LMEM region Matthew Auld
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 3/8] drm/i915: reserve stolen for " Matthew Auld
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 4/8] drm/i915: introduce mem->reserved Matthew Auld
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 5/8] drm/i915/dg1: Reserve first 1MB of local memory Matthew Auld
2021-01-27 12:58 ` Chris Wilson
2021-01-27 12:59 ` Chris Wilson
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 6/8] drm/i915: allocate context from LMEM Matthew Auld
2021-01-27 12:48 ` [Intel-gfx] [PATCH v4 7/8] drm/i915: move engine scratch to LMEM Matthew Auld
2021-01-27 12:48 ` Matthew Auld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127124809.384080-8-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.