From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8790C433E6 for ; Wed, 27 Jan 2021 20:00:53 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90C9864DA5 for ; Wed, 27 Jan 2021 20:00:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C9864DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5B42486C43; Wed, 27 Jan 2021 20:00:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MFLS0tfIgbgq; Wed, 27 Jan 2021 20:00:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id B81E886C0E; Wed, 27 Jan 2021 20:00:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A4A63C08A1; Wed, 27 Jan 2021 20:00:52 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A79FC013A for ; Wed, 27 Jan 2021 20:00:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 412E286277 for ; Wed, 27 Jan 2021 20:00:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qRCt429yrsYZ for ; Wed, 27 Jan 2021 20:00:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 075FE861D7 for ; Wed, 27 Jan 2021 20:00:50 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id n7so3482190oic.11 for ; Wed, 27 Jan 2021 12:00:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvRcBguN/96Hnzr6bI5Ag8OoiWzcrVtrxH3mL5ZfZ1o=; b=CcsHOrmXc/iJ+AHPlOUer0i77wq2zz8HqSHHS4q2NIgzFZ1BbIBFY7vTfOT28qjt+s iyBRfb2kJKQ+cEeeDtAafTMaK+/9AtZ4Z/1ud/K6wXWW/r5aMiGJpjwxq9Hv5fI945D/ vWXmmEwl/smu6P+Ec7LgB+mh//FFYvoJCYdZs/y/9ya+Zd5lW69WcUg5/To9gB7Kvm6r oYg2BGPXdO+o2XaLEYvNxalk/Fw3WI8G3IAd0SAjSLqKCiAasNLuNNTrPJTV+wiCPdLM NLHssuAXaIPvPPJHcoliMDXSlcntqyGeQoTUFh2xYXV76NDT6B7H8fqv3xvz1AeD2iaL SOVw== X-Gm-Message-State: AOAM530/wiMA7b0Msoj88FRyuq/iwUTc3yWzV4qnZ6yDETGYhQqnL1fI LWy6HSffWJuxqA3Jkfxs6A== X-Google-Smtp-Source: ABdhPJwMBL6J6h0Mdgp/mb0/qiCzzg22X3N+4Non2UUG6xKNUgZwnVj+ExesrC+lIcTiArkT8riPBA== X-Received: by 2002:aca:fcc5:: with SMTP id a188mr4342745oii.169.1611777649178; Wed, 27 Jan 2021 12:00:49 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z4sm625941ooz.5.2021.01.27.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 12:00:47 -0800 (PST) Received: (nullmailer pid 2143114 invoked by uid 1000); Wed, 27 Jan 2021 20:00:46 -0000 Date: Wed, 27 Jan 2021 14:00:46 -0600 From: Rob Herring To: Yong Wu Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges Message-ID: <20210127200046.GA2142347@robh.at.kernel.org> References: <20210119105203.15530-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119105203.15530-1-yong.wu@mediatek.com> Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Will Deacon , Frank Rowand , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Paul Kocialkowski , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote: > The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > supplanting dma_pfn_offset") always update dma_range_map even though it was > already set, like in the sunxi_mbus driver. the issue is reported at [1]. > This patch avoid this(Updating it only when dev has valid dma-ranges). > > Meanwhile, dma_range_map contains the devices' dma_ranges information, > This patch moves dma_range_map before of_iommu_configure. The iommu > driver may need to know the dma_address requirements of its iommu > consumer devices. > > [1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks! _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6892DC433DB for ; Wed, 27 Jan 2021 20:01:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AF2664DA3 for ; Wed, 27 Jan 2021 20:01:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF2664DA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a679FLfzZbIB9xqCzhTuZfb5wKCUkg19ehuu+E3RRFo=; b=wrc+nEIwdKaLj2pPWFXX5zjM4 zFFZj7bV+LIXiCUu46RFcIvn0Uvy8s1Jqa+qS5KDd0OjQnApgnPrQDQxJiZ1Ycs7cJAOERwuCwrjW JbLDhzBE6u5GDIAan9aMj8qs3jf4GCyneC0NMtRTTfZbs1ZHFi08bK10/fbuGCdsaCGQSXij2SDjC aF+uCq5MiPTRy3RgVTxhZOo2Huyfwymek/jU/tT0roNO2WhsnZM3MUhXTjppQyfqFwzINrd4Z5uaM HrWHQbiIZh6vSNnlWNwrrhruwyDc2SN5BLWZFfbqYF8tkm8rpB3+0sWxLO1XzYTy7b/kCHOV1FqA+ zoyMnCeOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzo-0006iG-Sa; Wed, 27 Jan 2021 20:00:56 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzk-0006fr-5A; Wed, 27 Jan 2021 20:00:53 +0000 Received: by mail-oi1-f172.google.com with SMTP id k25so3478216oik.13; Wed, 27 Jan 2021 12:00:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvRcBguN/96Hnzr6bI5Ag8OoiWzcrVtrxH3mL5ZfZ1o=; b=SxircyTDGQ3Ho2ItfZ8BDGqxylH9qvfpKmI4GKHdYL1vMVOulHa2aWZeldCUPvUHSZ c3PYKo1SatfTH3zEuIPfWCLBbSx8rBy7IlN4WqPXf9/oUyufhYJbRLST/8lZbLuKhGys dospl+qP8UFVubQbU9AShBDaHJ6Wv7xpdt8o1dzyMWhHGVzrsOY2lOfOOl+SuLCdMKRI vf4wvUP3s4JaOLvtgCotF4QaGEGb29iCkMUq7oi0Wg3BegzOyY1/AUbDv4bHsgJ5rmWg WCHmv/z9rrmpFVc5O954/IKhF1EdwSudFQyTfgfKbvHdaNI0CMagdrK4m+YxtLs5FVw2 eCVw== X-Gm-Message-State: AOAM531pJqe+zbfq8Q4Ns2K0LvOP0hjS4bwksNdGvD7/HpZbX7yO6Cpj 6FEoyBEWQNB8uCmxbnuKHw== X-Google-Smtp-Source: ABdhPJwMBL6J6h0Mdgp/mb0/qiCzzg22X3N+4Non2UUG6xKNUgZwnVj+ExesrC+lIcTiArkT8riPBA== X-Received: by 2002:aca:fcc5:: with SMTP id a188mr4342745oii.169.1611777649178; Wed, 27 Jan 2021 12:00:49 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z4sm625941ooz.5.2021.01.27.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 12:00:47 -0800 (PST) Received: (nullmailer pid 2143114 invoked by uid 1000); Wed, 27 Jan 2021 20:00:46 -0000 Date: Wed, 27 Jan 2021 14:00:46 -0600 From: Rob Herring To: Yong Wu Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges Message-ID: <20210127200046.GA2142347@robh.at.kernel.org> References: <20210119105203.15530-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119105203.15530-1-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_150052_209499_85953F2A X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Will Deacon , Frank Rowand , Joerg Roedel , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Paul Kocialkowski , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote: > The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > supplanting dma_pfn_offset") always update dma_range_map even though it was > already set, like in the sunxi_mbus driver. the issue is reported at [1]. > This patch avoid this(Updating it only when dev has valid dma-ranges). > > Meanwhile, dma_range_map contains the devices' dma_ranges information, > This patch moves dma_range_map before of_iommu_configure. The iommu > driver may need to know the dma_address requirements of its iommu > consumer devices. > > [1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DC8BC433DB for ; Wed, 27 Jan 2021 20:02:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5DF064DA5 for ; Wed, 27 Jan 2021 20:02:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5DF064DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u8uXOpIoPyS4iSniY4QzoNebF9Yt0Kjzu0pdJZc4G/o=; b=sHsQRWHaeLd36nSUtYHfUrh30 TfJNbRL2wMxeIEcdgeUGcn20Xw7FnhYF663qCxqVh/dnyEWx/pC1WdgHLIrETyg+99GOACxwrHwgc bOV1gQ8lRPjg5XUfB39t0oPbrax4eXaoQ/fusf06jFcqlYCnlSN7pS+PzA+FVS/SXyJ6rN564Lf3d GRe2YSqvtjcMREOXbgp+pfl3SqQx5ng+n9sABrLVFN319ZtEBHejJiwnVSTjTehy79LmugkMn579G ZCzFf0+2yUDHoPXnFis5e7HCWrqMnsJ7dUwvbdARXmHrjKgmmKSRjHleuIgEztpMilGHEm8DWEydC hi+3JI6SA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzm-0006hd-Rg; Wed, 27 Jan 2021 20:00:54 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qzk-0006fr-5A; Wed, 27 Jan 2021 20:00:53 +0000 Received: by mail-oi1-f172.google.com with SMTP id k25so3478216oik.13; Wed, 27 Jan 2021 12:00:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvRcBguN/96Hnzr6bI5Ag8OoiWzcrVtrxH3mL5ZfZ1o=; b=SxircyTDGQ3Ho2ItfZ8BDGqxylH9qvfpKmI4GKHdYL1vMVOulHa2aWZeldCUPvUHSZ c3PYKo1SatfTH3zEuIPfWCLBbSx8rBy7IlN4WqPXf9/oUyufhYJbRLST/8lZbLuKhGys dospl+qP8UFVubQbU9AShBDaHJ6Wv7xpdt8o1dzyMWhHGVzrsOY2lOfOOl+SuLCdMKRI vf4wvUP3s4JaOLvtgCotF4QaGEGb29iCkMUq7oi0Wg3BegzOyY1/AUbDv4bHsgJ5rmWg WCHmv/z9rrmpFVc5O954/IKhF1EdwSudFQyTfgfKbvHdaNI0CMagdrK4m+YxtLs5FVw2 eCVw== X-Gm-Message-State: AOAM531pJqe+zbfq8Q4Ns2K0LvOP0hjS4bwksNdGvD7/HpZbX7yO6Cpj 6FEoyBEWQNB8uCmxbnuKHw== X-Google-Smtp-Source: ABdhPJwMBL6J6h0Mdgp/mb0/qiCzzg22X3N+4Non2UUG6xKNUgZwnVj+ExesrC+lIcTiArkT8riPBA== X-Received: by 2002:aca:fcc5:: with SMTP id a188mr4342745oii.169.1611777649178; Wed, 27 Jan 2021 12:00:49 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z4sm625941ooz.5.2021.01.27.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 12:00:47 -0800 (PST) Received: (nullmailer pid 2143114 invoked by uid 1000); Wed, 27 Jan 2021 20:00:46 -0000 Date: Wed, 27 Jan 2021 14:00:46 -0600 From: Rob Herring To: Yong Wu Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges Message-ID: <20210127200046.GA2142347@robh.at.kernel.org> References: <20210119105203.15530-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119105203.15530-1-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_150052_209499_85953F2A X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Will Deacon , Frank Rowand , Joerg Roedel , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Paul Kocialkowski , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote: > The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > supplanting dma_pfn_offset") always update dma_range_map even though it was > already set, like in the sunxi_mbus driver. the issue is reported at [1]. > This patch avoid this(Updating it only when dev has valid dma-ranges). > > Meanwhile, dma_range_map contains the devices' dma_ranges information, > This patch moves dma_range_map before of_iommu_configure. The iommu > driver may need to know the dma_address requirements of its iommu > consumer devices. > > [1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17058C433DB for ; Wed, 27 Jan 2021 20:03:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C977564DA5 for ; Wed, 27 Jan 2021 20:03:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbhA0UC7 (ORCPT ); Wed, 27 Jan 2021 15:02:59 -0500 Received: from mail-oi1-f170.google.com ([209.85.167.170]:35854 "EHLO mail-oi1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbhA0UBa (ORCPT ); Wed, 27 Jan 2021 15:01:30 -0500 Received: by mail-oi1-f170.google.com with SMTP id d18so3523380oic.3; Wed, 27 Jan 2021 12:01:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvRcBguN/96Hnzr6bI5Ag8OoiWzcrVtrxH3mL5ZfZ1o=; b=tVmyxrE93w8bvPxNtz9EUy+98rnwQ79FsIxgTNw4pmXe9LTMTlGMZG2C/gf86tlZiv d/m+kB9gtrtU4zcc2t6pJacvRSyQnuaOiSDrGoTL5MWA06ftPFhtEerZgSb7wJGn5+vx pLokbIu9nrCb6bf/oDelS/lA0ehfAbpuRMLXaXxQ9McuGD/30xGydMK9hKTmdsIIYoOc Xsbv6tBEtHH/Gsnml9MZbBf7NL1N9BiRjf5eDFLN8LJ++VI9n+rjMhgI7+zS/GMaI0fj Ke0MNWSGkaO2I3aaPSaZTvjmBBYhUml83HpbXTxDxtbNA62+opwhqGykGCsFcpAl8XRc b1LA== X-Gm-Message-State: AOAM533/pQoMZzt+sB3YzBREQvHrd0duvP1kNmRRnumswyXYShv/AVfz 7yNIlOxrSVTGFMWE72jAlp3iMl6GQA== X-Google-Smtp-Source: ABdhPJwMBL6J6h0Mdgp/mb0/qiCzzg22X3N+4Non2UUG6xKNUgZwnVj+ExesrC+lIcTiArkT8riPBA== X-Received: by 2002:aca:fcc5:: with SMTP id a188mr4342745oii.169.1611777649178; Wed, 27 Jan 2021 12:00:49 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z4sm625941ooz.5.2021.01.27.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 12:00:47 -0800 (PST) Received: (nullmailer pid 2143114 invoked by uid 1000); Wed, 27 Jan 2021 20:00:46 -0000 Date: Wed, 27 Jan 2021 14:00:46 -0600 From: Rob Herring To: Yong Wu Cc: Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Kocialkowski , Tomasz Figa , Robin Murphy , Matthias Brugger , devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Will Deacon , srv_heupstream@mediatek.com, Nicolas Boichat , Joerg Roedel Subject: Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges Message-ID: <20210127200046.GA2142347@robh.at.kernel.org> References: <20210119105203.15530-1-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119105203.15530-1-yong.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote: > The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > supplanting dma_pfn_offset") always update dma_range_map even though it was > already set, like in the sunxi_mbus driver. the issue is reported at [1]. > This patch avoid this(Updating it only when dev has valid dma-ranges). > > Meanwhile, dma_range_map contains the devices' dma_ranges information, > This patch moves dma_range_map before of_iommu_configure. The iommu > driver may need to know the dma_address requirements of its iommu > consumer devices. > > [1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Applied, thanks!