All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-usb@vger.kernel.org,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Andreas Noever <andreas.noever@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 2/5] thunderbolt: eeprom: Fix kernel-doc descriptions of non-static functions
Date: Thu, 28 Jan 2021 21:57:19 +0100	[thread overview]
Message-ID: <20210128205719.GA7956@wunner.de> (raw)
In-Reply-To: <20210128122934.36897-3-mika.westerberg@linux.intel.com>

On Thu, Jan 28, 2021 at 03:29:31PM +0300, Mika Westerberg wrote:
>  /**
> - * tb_drom_read - copy drom to sw->drom and parse it
> + * tb_drom_read() - Copy DROM to sw->drom and parse it
> + * @sw: Router whose DROM to read and parse
> + *
> + * This function reads router DROM and if successful parses the entries and
> + * populates the fields in @sw accordingly. Can be called for any router
> + * generation.
> + *
> + * Returns %0 in case of success and negative errno otherwise.
>   */
>  int tb_drom_read(struct tb_switch *sw)
>  {

I'm confused by the terminology change of "router" vs. "switch".
Is this change mandated by USB4?

The parameter is a tb_switch, so calling it a router looks a little odd.

Thanks,

Lukas

  parent reply	other threads:[~2021-01-28 21:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 12:29 [PATCH 0/5] thunderbolt: Fix kernel-doc descriptions of non-static functions Mika Westerberg
2021-01-28 12:29 ` [PATCH 1/5] thunderbolt: ctl: " Mika Westerberg
2021-01-28 13:13   ` Lee Jones
2021-01-28 12:29 ` [PATCH 2/5] thunderbolt: eeprom: " Mika Westerberg
2021-01-28 13:11   ` Lee Jones
2021-01-28 14:22     ` Mika Westerberg
2021-01-28 14:40       ` Lee Jones
2021-01-28 20:57   ` Lukas Wunner [this message]
2021-01-29  7:04     ` Mika Westerberg
2021-01-28 12:29 ` [PATCH 3/5] thunderbolt: path: " Mika Westerberg
2021-01-28 13:11   ` Lee Jones
2021-01-28 12:29 ` [PATCH 4/5] thunderbolt: nhi: " Mika Westerberg
2021-01-28 13:07   ` Lee Jones
2021-01-28 12:29 ` [PATCH 5/5] thunderbolt: switch: " Mika Westerberg
2021-01-28 13:06   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128205719.GA7956@wunner.de \
    --to=lukas@wunner.de \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.