From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Thu, 28 Jan 2021 21:25:34 +0000 Subject: Re: [PATCH] mtd: parser_imagetag: fix error codes in bcm963xx_parse_imagetag_partitions() Message-Id: <20210128212534.2242-1-miquel.raynal@bootlin.com> List-Id: In-Reply-To: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Miquel Raynal Cc: Rob Herring , Florian Fainelli , Vignesh Raghavendra , Richard Weinberger , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Jonas Gorski On Thu, 2021-01-28 at 09:36:52 UTC, Dan Carpenter wrote: > If the kstrtouint() calls fail, then this should return a negative > error code but it currently returns success. > > Fixes: dd84cb022b31 ("mtd: bcm63xxpart: move imagetag parsing to its own parser") > Signed-off-by: Dan Carpenter Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27947C433E0 for ; Thu, 28 Jan 2021 21:26:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87BF064DE8 for ; Thu, 28 Jan 2021 21:26:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87BF064DE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/2myZ68e78aCUoSo7v0VMrRupcrZKuRdO2dijNC/aO0=; b=iIYk+UogXmnR9vSSPDIsR99pD 0ngNl5+XAr/u1rIM64p5ZVhJyDWn85uJ0U7wycHLCSal5iNeOfZ9rCzoRxWw7Q3EOZSae3gZ8H3Sr fAk6qCTt8ctq1sv6b/9jy3ATptZCvSDt0ttUK84436Ys0dyHTpgNglVECpk2OXo/zM1rHXWa3Xi0r ucHLB/KR7RRyK5WDeD/hNgzb+dzUbsndA+W6iXhgD9QRVpRnyfiEzlbK01B8ni8oeu9UUAqQm+v/T jXBgoHyQAkuYXmgRqpM3XhuLTEDGKtTIU93JCMTYY+W5/6Yf3Vu9D1JjVJLHcAnJnLmBJ8d5HZzWF l4LIS9pZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5EnR-0000zA-Gk; Thu, 28 Jan 2021 21:25:45 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5EnO-0000yM-Nk for linux-mtd@lists.infradead.org; Thu, 28 Jan 2021 21:25:43 +0000 X-Originating-IP: 86.210.203.150 Received: from localhost.localdomain (lfbn-tou-1-972-150.w86-210.abo.wanadoo.fr [86.210.203.150]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D751040003; Thu, 28 Jan 2021 21:25:34 +0000 (UTC) From: Miquel Raynal To: Dan Carpenter , Miquel Raynal Subject: Re: [PATCH] mtd: parser_imagetag: fix error codes in bcm963xx_parse_imagetag_partitions() Date: Thu, 28 Jan 2021 22:25:34 +0100 Message-Id: <20210128212534.2242-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 12ba8f8ce29fdd277f3100052eddc1afd2f5ea3f X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_162542_986563_166877EE X-CRM114-Status: UNSURE ( 6.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Florian Fainelli , Vignesh Raghavendra , Richard Weinberger , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Jonas Gorski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 2021-01-28 at 09:36:52 UTC, Dan Carpenter wrote: > If the kstrtouint() calls fail, then this should return a negative > error code but it currently returns success. > > Fixes: dd84cb022b31 ("mtd: bcm63xxpart: move imagetag parsing to its own parser") > Signed-off-by: Dan Carpenter Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1289C433DB for ; Thu, 28 Jan 2021 21:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B6A064DE8 for ; Thu, 28 Jan 2021 21:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231479AbhA1V0f (ORCPT ); Thu, 28 Jan 2021 16:26:35 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:54257 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231374AbhA1V0V (ORCPT ); Thu, 28 Jan 2021 16:26:21 -0500 X-Originating-IP: 86.210.203.150 Received: from localhost.localdomain (lfbn-tou-1-972-150.w86-210.abo.wanadoo.fr [86.210.203.150]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D751040003; Thu, 28 Jan 2021 21:25:34 +0000 (UTC) From: Miquel Raynal To: Dan Carpenter , Miquel Raynal Cc: Rob Herring , Florian Fainelli , Vignesh Raghavendra , Richard Weinberger , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Jonas Gorski Subject: Re: [PATCH] mtd: parser_imagetag: fix error codes in bcm963xx_parse_imagetag_partitions() Date: Thu, 28 Jan 2021 22:25:34 +0100 Message-Id: <20210128212534.2242-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 12ba8f8ce29fdd277f3100052eddc1afd2f5ea3f Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-01-28 at 09:36:52 UTC, Dan Carpenter wrote: > If the kstrtouint() calls fail, then this should return a negative > error code but it currently returns success. > > Fixes: dd84cb022b31 ("mtd: bcm63xxpart: move imagetag parsing to its own parser") > Signed-off-by: Dan Carpenter Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel