From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81088C433E0 for ; Fri, 29 Jan 2021 10:14:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0ED64E70 for ; Fri, 29 Jan 2021 10:14:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F0ED64E70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tlfbsp6HA/GcKC/aiJf1AqCzHv3X0gGkQ9wrF4irqtY=; b=lRAoubVvP/uT1o9cNpp8gBZ0R cH8ssp2ehIvu7AuHzBfVc3ketK0gZxXRhHkZyL2RGyx9YhCCm06iDW4u18g6Nn1E4D6+1WQQupGEP Z8YVQCw701HlDePyB4GoM4YpzaFpzlHYE4RvDC2zTik78iDHZMODkt28mTMUfGT3mSkfZiYyie068 6CUucIzMUONlgHDztUWjSOPsxk2iPQAuvVkFmCjtvUDCmfE9Td0yrieZkKpzuDB//+2kicK7cEPqt pFnru+JYmeBF/3jjFKuaNB0Szvo8Oe8fXW9TQvVJJzS6yYTr+oKl6tMqqUEDCxYhpQXKFCseZVnhK YODPet7Tw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Qm4-0000zP-KI; Fri, 29 Jan 2021 10:13:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Qm1-0000y9-65 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 10:13:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wa/CZmFFJTXLZMO/jqdbmUJdLckWXijIdDSCiGW2FBw=; b=XbD5PqZqsMaQF8HXWolJaMcv2 8IoqryS/6Ig8Ma9JB6SUcTwW/HQy3XkqcJORx5hdKit4S21CVFP2e0r+EVOUcnS/ZPT8XdBiWoW/j BbFj6ceLtn6Yh56ugHISkcW4AhgX7uCgl1A2ynCnfQLzbQZm6Zw/apwGHAZOfLFPsd2NQDiHzTxyJ XpnBnTsdScW3HDW+m91FpVOU1accpNanr9nTJDf5JcpfJmBAVVCkp9J8lKLtkF4q4OiE2IUOvIsaD Q0phtNHq+aOx0RBIzJIPtPMtd2V1RWOKAmrTALBDqYqvTbjfI9NFcZ8F+UJJYMmTKrHZvMwZkFZG0 a+tKnnFjw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54170) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5Qlh-0000rr-7Z; Fri, 29 Jan 2021 10:12:45 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1l5Qle-0006o8-C6; Fri, 29 Jan 2021 10:12:42 +0000 Date: Fri, 29 Jan 2021 10:12:42 +0000 From: Russell King - ARM Linux admin To: "Leizhen (ThunderTown)" Subject: Re: [PATCH v5 4/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller Message-ID: <20210129101242.GV1551@shell.armlinux.org.uk> References: <20210116032740.873-1-thunder.leizhen@huawei.com> <20210116032740.873-5-thunder.leizhen@huawei.com> <20dac713-25b7-cddf-cc42-69a834487c71@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20dac713-25b7-cddf-cc42-69a834487c71@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_051305_251137_142CA0D2 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Arnd Bergmann , devicetree , Greg Kroah-Hartman , Will Deacon , linux-kernel , Haojian Zhuang , Rob Herring , Wei Xu , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 29, 2021 at 03:23:27PM +0800, Leizhen (ThunderTown) wrote: > On 2021/1/28 22:24, Arnd Bergmann wrote: > > I see that cache-l2x0 uses raw_spin_lock_irqsave() instead of > > spin_lock_irqsave(), to avoid preemption in the middle of a cache > > operation. This is probably a good idea here as well. > > I don't think there's any essential difference between the two! I don't know > if the compiler or tool will do anything extra. I checked the git log of the > l2x0 driver and it used raw_spin_lock_irqsave() at the beginning. Maybe > there's a description in 2.6. Since you mentioned this potential risk, I'll > change it to raw_spin_lock_irqsave. See bd31b85960a7 ("locking, ARM: Annotate low level hw locks as raw") -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel