From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000DEC433E0 for ; Sat, 30 Jan 2021 11:29:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE15764E0B for ; Sat, 30 Jan 2021 11:29:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE15764E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7D786ECAC; Sat, 30 Jan 2021 11:29:10 +0000 (UTC) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by gabe.freedesktop.org (Postfix) with ESMTPS id 940DC6EB18 for ; Fri, 29 Jan 2021 12:47:41 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id md11so5756842pjb.0 for ; Fri, 29 Jan 2021 04:47:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=gey6ZY0toHv6VOmxg4G7/z9gStOYikqSFh5g6TpL77g=; b=vXuqtJc1idgNU9yQCo/fp7Ab+usyyyfz1rSAqGtMgWtscmTnt8AT0BdLItHL2GlrXk gkQmfIP6Z4ygt7lY4rgpNd/7dGSgSR7JEiYxoOkcy5wpVlMS0eYu0/UgLLUPxNt1kMLS b2E/+9KjqTf9Q9BOZMpWXbC+Hdn1uGfY0NqP4oA7G2kArYNox63IVCU3KqqkVF9TdIWY 6ukXjx71x12HkKZTJJ2sapPY+W13ItMFJmVurVOiPIuqBc18o4LXBawyUsaNk/SKg8qc 9+pZHOFFQ7TifaeYRrP4QKIDZU5g4SrAkESSsWNbFKMZ1o2boq4S3tpqHNQVh3nriy8Y KgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=gey6ZY0toHv6VOmxg4G7/z9gStOYikqSFh5g6TpL77g=; b=AE8lLB9J5jhgYioYvKGPJTk1ipibiuF6HRsCdi9erAutGNXG9tjQMZPtHwa9pmq/Fe TIpHefd3JYQZPOFDGrQy6Q7X+ntID3Q1erEHEvA+7FDv+Ykt3HWonpTPNncR9dYxQ4zl JAEVzAIfzsmA9C2tfwrAoCEea9kuxJn8p0Ufrp2AJK4d0VfQW83kpqWO3fLPuMCj/hFK 2BgIOKOKO2rkgw9bD9bM7TkFUuTZpzznAXhbITaaZsC+9hBwFhg1Ov+W//LDmLIAywxz O3b+h5e88PrTxvMtVN27zHYsIPlphceV4//ryzOd4HBsszZYxXeqAD3KMOFlJA3elsTF AFlA== X-Gm-Message-State: AOAM530L4wQDpnhWKooRz9uHOwncLxIlAkVgyh1tj/XuA8tV9VXOABcy bnaaEYSggVB0FscMmnNjfHQ= X-Google-Smtp-Source: ABdhPJzrUKpZVmxy7aREzbzLAECwsJsp1TVGwWCQ4IACdk/D7pTSz/Vr2FguW3H0pi0FGnZzWRgFdw== X-Received: by 2002:a17:902:ab93:b029:df:f681:cdf3 with SMTP id f19-20020a170902ab93b02900dff681cdf3mr4248655plr.28.1611924461212; Fri, 29 Jan 2021 04:47:41 -0800 (PST) Received: from localhost ([103.220.76.197]) by smtp.gmail.com with ESMTPSA id 21sm8415028pfh.56.2021.01.29.04.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 04:47:40 -0800 (PST) Date: Fri, 29 Jan 2021 20:47:33 +0800 From: carlis To: Andy Shevchenko Subject: Re: [PATCH v12] staging: fbtft: add tearing signal detect Message-ID: <20210129204733.00003954@gmail.com> In-Reply-To: References: <1611838435-151774-1-git-send-email-zhangxuezhi3@gmail.com> <20210129130110.00003bb1@gmail.com> Organization: Tyzmig-ryrjum-8kedto X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 30 Jan 2021 11:28:30 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:STAGING SUBSYSTEM" , "open list:FRAMEBUFFER LAYER" , Deepak R Varma , Greg Kroah-Hartman , oliver.graute@kococonnector.com, Linux Kernel Mailing List , dri-devel , Stefano Brivio , Colin King , zhangxuezhi1@yulong.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 29 Jan 2021 12:23:08 +0200 Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 7:01 AM carlis wrote: > > On Thu, 28 Jan 2021 16:33:02 +0200 > > Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 2:58 PM Carlis > > > wrote: > > > > > > Thanks for your contribution, my comments below. > > > > > > > From: zhangxuezhi > > > > > > You probably have to configure your Git to use the same account > > > for author and committer. > > > > hi,you mean like below: > > Carlis > > ? > > I meant that you shouldn't probably have a From: line in the commit > message. > > ... > > > hi, i have modified it according to your suggestion like below: > > Please, go again thru my comments and comments from others and > carefully address all of them everywhere in your contribution. If you > have questions, ask them in reply in the corresponding context. > > ... > > > /** > > * init_tearing_effect_line() - init tearing effect line > > > * > > For example, above was commented on and hasn't been addressed here. > hi,here i can not get you..... > > * @par: FBTFT parameter object > > * > > * Return: 0 on success, < 0 if error occurred. > > */ > > static int init_tearing_effect_line(struct fbtft_par *par) > > { > > struct device *dev = par->info->device; > > struct gpio_desc *te; > > int rc; > > > > te = gpiod_get_optional(dev, "te", GPIOD_IN); > > if (IS_ERR(te)) > > return dev_err_probe(dev, PTR_ERR(te), "Failed to > > request te GPIO\n"); > > > > > if (te) { > > This one is not like I suggested. Why? My thinking is that if the TE is not configured and NULL is returned, the initialization can still proceed..... > > > par->irq_te = gpiod_to_irq(te); > > gpiod_put(te); > > > > > if (par->irq_te) { > > This is wrong. Why? i have read gpiod_to_irq code, if an error occurs, a negative value is returned, and zero is not possible,so I need this value to determine if TE IRQ is configured > > > rc = devm_request_irq(dev, > > par->irq_te, > > panel_te_handler, > > IRQF_TRIGGER_RISING, > > "TE_GPIO", par); > > Try to use less LOCs. > > > if (rc) > > return dev_err_probe(dev, rc, "TE > > IRQ request failed.\n"); > > > > disable_irq_nosync(par->irq_te); > > init_completion(&par->panel_te); > > > } else { > > return dev_err_probe(dev, par->irq_te, > > "gpiod to TE IRQ failed.\n"); > > } > > Again, it is not what had been suggested. > > > } > > > > return 0; > > } > > The rest is better, but we will see later on when you submit a new > version (And I feel it won't be last). > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel