All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lijun Pan <ljp@linux.ibm.com>
To: netdev@vger.kernel.org
Cc: sukadev@linux.ibm.com, drt@linux.ibm.com,
	brking@linux.vnet.ibm.com, dnbanerg@us.ibm.com,
	tlfalcon@linux.ibm.com, Lijun Pan <ljp@linux.ibm.com>
Subject: [PATCH net-next v2 2/2] ibmvnic: remove unnecessary rmb() inside ibmvnic_poll
Date: Fri, 29 Jan 2021 19:19:05 -0600	[thread overview]
Message-ID: <20210130011905.1485-3-ljp@linux.ibm.com> (raw)
In-Reply-To: <20210130011905.1485-1-ljp@linux.ibm.com>

rmb() can be removed since:
1. pending_scrq() has dma_rmb() at the function end;
2. dma_rmb(), though weaker, is enough here.

Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Acked-by: Dwip Banerjee <dnbanerg@us.ibm.com>
Acked-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 331ebca2f57a..0ed169ef1cfc 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -2510,7 +2510,6 @@ static int ibmvnic_poll(struct napi_struct *napi, int budget)
 		if (napi_complete_done(napi, frames_processed)) {
 			enable_scrq_irq(adapter, rx_scrq);
 			if (pending_scrq(adapter, rx_scrq)) {
-				rmb();
 				if (napi_reschedule(napi)) {
 					disable_scrq_irq(adapter, rx_scrq);
 					goto restart_poll;
-- 
2.23.0


  parent reply	other threads:[~2021-01-30 10:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30  1:19 [PATCH net-next v2 0/2] rework the memory barrier for SCRQ entry Lijun Pan
2021-01-30  1:19 ` [PATCH net-next v2 1/2] ibmvnic: rework to ensure SCRQ entry reads are properly ordered Lijun Pan
2021-01-30  1:19 ` Lijun Pan [this message]
2021-02-02  4:30 ` [PATCH net-next v2 0/2] rework the memory barrier for SCRQ entry patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210130011905.1485-3-ljp@linux.ibm.com \
    --to=ljp@linux.ibm.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=dnbanerg@us.ibm.com \
    --cc=drt@linux.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=sukadev@linux.ibm.com \
    --cc=tlfalcon@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.