From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-doc <linux-doc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 8/8] gpio: sim: new testing module
Date: Sun, 31 Jan 2021 08:43:08 +0800 [thread overview]
Message-ID: <20210131004308.GA4687@sol> (raw)
In-Reply-To: <CAMRc=MeSy4zWOAGxfoBih62WxAXuOLtkK3ROyt+4LuqLvDxtaQ@mail.gmail.com>
On Sat, Jan 30, 2021 at 09:37:55PM +0100, Bartosz Golaszewski wrote:
> On Fri, Jan 29, 2021 at 4:57 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Fri, Jan 29, 2021 at 02:46:24PM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ...
> >
[snip]
> > Honestly, I don't like the idea of Yet Another (custom) Parser in the kernel.
> >
> > Have you investigated existing parsers? We have cmdline.c, gpio-aggregator.c,
> > etc. Besides the fact of test cases which are absent here. And who knows what
> > we allow to be entered.
> >
>
> Yes, I looked all around the kernel to find something I could reuse
> but failed to find anything useful for this particular purpose. If you
> have something you could point me towards, I'm open to alternatives.
>
> Once we agree on the form of the module, I'll port self-tests to using
> it instead of gpio-mockup, so we'll have some tests in the tree.
>
Given the existing selftests focus on testing the gpio-mockup itself, it
would be more appropriate that you add separate tests for gpio-sim.
As an end user I'm interested in the concrete example of driving gpio-sim
that selftests would provide, so I'm looking forward to seeing that.
Cheers,
Kent.
next prev parent reply other threads:[~2021-01-31 0:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210129134624.9247-1-brgl@bgdev.pl>
[not found] ` <20210129134624.9247-6-brgl@bgdev.pl>
[not found] ` <YBQw3+K/6GDPK5xa@smile.fi.intel.com>
2021-01-30 20:25 ` [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-02-01 10:19 ` Andy Shevchenko
[not found] ` <20210129134624.9247-9-brgl@bgdev.pl>
[not found] ` <YBQwUkQz3LrG5G4i@smile.fi.intel.com>
2021-01-30 20:37 ` [PATCH 8/8] gpio: sim: new testing module Bartosz Golaszewski
2021-01-31 0:43 ` Kent Gibson [this message]
2021-02-01 8:37 ` Bartosz Golaszewski
2021-02-01 10:28 ` Andy Shevchenko
2021-02-01 10:59 ` Bartosz Golaszewski
2021-02-01 12:49 ` Andy Shevchenko
2021-02-01 12:53 ` Bartosz Golaszewski
2021-02-01 13:30 ` Andy Shevchenko
2021-01-30 21:20 ` [PATCH 0/8] gpio: implement the configfs " Uwe Kleine-König
2021-02-01 8:37 ` Bartosz Golaszewski
2021-02-01 9:24 ` Uwe Kleine-König
2021-02-01 12:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210131004308.GA4687@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.