From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49DEC433E0 for ; Sun, 31 Jan 2021 22:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A379D64E09 for ; Sun, 31 Jan 2021 22:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229500AbhAaWyS (ORCPT ); Sun, 31 Jan 2021 17:54:18 -0500 Received: from onstation.org ([52.200.56.107]:47748 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbhAaWyN (ORCPT ); Sun, 31 Jan 2021 17:54:13 -0500 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 3A72B3F0B3; Sun, 31 Jan 2021 22:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1612133612; bh=zBA2yPYI5rqrcZZX1WyKJXmK/xwJfSI0vnhAopp38lQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ii5/ljccGSGrgtlADn5zOAj21GGPnpw4RRDjpazsXOUkwjZaqsawZWC4VsO99bEH3 ff4Hu+ztI9Z5B3A2/CaZZhFdtWTL4hTA/ixFXpPItkWXJdGdadWUCjh6bUlGU4Byts imNHm+yQuGvAEQmsCq0cyIgTRn8YtN/Rphb/MhzA= Date: Sun, 31 Jan 2021 17:53:30 -0500 From: Brian Masney To: Iskren Chernev Cc: Rob Clark , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , David Airlie , Daniel Vetter , Thomas Zimmermann , Maxime Ripard , Abhinav Kumar , Emil Velikov , Christophe JAILLET , Lee Jones , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels Message-ID: <20210131225330.GA7982@onstation.org> References: <20210127152442.533468-1-iskren.chernev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jan 27, 2021 at 05:24:40PM +0200, Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async commits are done. > > For cmd panels the source of wait_flush is a ping-pong irq notifying > a completion. The completion needs to be notified with complete_all so > multiple waiting parties (new async committers) can proceed. > > Signed-off-by: Iskren Chernev > Suggested-by: Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") Nice job tracking down this fix! Reviewed-by: Brian Masney Tested-by: Brian Masney From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B1EC433DB for ; Mon, 1 Feb 2021 08:11:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64AC764E24 for ; Mon, 1 Feb 2021 08:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64AC764E24 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56B466E43C; Mon, 1 Feb 2021 08:11:07 +0000 (UTC) Received: from onstation.org (onstation.org [52.200.56.107]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EAA86E134; Sun, 31 Jan 2021 22:53:34 +0000 (UTC) Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 3A72B3F0B3; Sun, 31 Jan 2021 22:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1612133612; bh=zBA2yPYI5rqrcZZX1WyKJXmK/xwJfSI0vnhAopp38lQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ii5/ljccGSGrgtlADn5zOAj21GGPnpw4RRDjpazsXOUkwjZaqsawZWC4VsO99bEH3 ff4Hu+ztI9Z5B3A2/CaZZhFdtWTL4hTA/ixFXpPItkWXJdGdadWUCjh6bUlGU4Byts imNHm+yQuGvAEQmsCq0cyIgTRn8YtN/Rphb/MhzA= Date: Sun, 31 Jan 2021 17:53:30 -0500 From: Brian Masney To: Iskren Chernev Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels Message-ID: <20210131225330.GA7982@onstation.org> References: <20210127152442.533468-1-iskren.chernev@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com> X-Mailman-Approved-At: Mon, 01 Feb 2021 08:11:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , Lee Jones , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Christophe JAILLET , ~postmarketos/upstreaming@lists.sr.ht, Thomas Zimmermann , linux-arm-msm@vger.kernel.org, Emil Velikov , Sean Paul , Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jan 27, 2021 at 05:24:40PM +0200, Iskren Chernev wrote: > Before the offending commit in msm_atomic_commit_tail wait_flush was > called once per frame, after the commit was submitted. After it > wait_flush is also called at the beginning to ensure previous > potentially async commits are done. > > For cmd panels the source of wait_flush is a ping-pong irq notifying > a completion. The completion needs to be notified with complete_all so > multiple waiting parties (new async committers) can proceed. > > Signed-off-by: Iskren Chernev > Suggested-by: Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") Nice job tracking down this fix! Reviewed-by: Brian Masney Tested-by: Brian Masney _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel