From: Huang Rui <ray.huang@amd.com>
To: "Du, Xiaojian" <Xiaojian.Du@amd.com>
Cc: "Wang, Kevin\(Yang\)" <Kevin1.Wang@amd.com>,
"Quan, Evan" <Evan.Quan@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/pm: remove some useless code for vangogh
Date: Mon, 1 Feb 2021 17:03:47 +0800 [thread overview]
Message-ID: <20210201090347.GC3140926@hr-amd> (raw)
In-Reply-To: <20210201084558.21708-1-Xiaojian.Du@amd.com>
On Mon, Feb 01, 2021 at 04:45:58PM +0800, Du, Xiaojian wrote:
> This patch is to remove some useless code for vangogh.
> In the earlier code, vangogh can't finish all the sequence of
> smu late init. But now vangogh has one stable work state,so
> remove the useless code.
>
> Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index f958b02f9317..30e2a0ac3279 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -612,9 +612,6 @@ static int smu_late_init(void *handle)
> return ret;
> }
>
> - if (adev->asic_type == CHIP_VANGOGH)
> - return 0;
> -
> ret = smu_set_default_od_settings(smu);
> if (ret) {
> dev_err(adev->dev, "Failed to setup default OD settings!\n");
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-02-01 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 8:45 [PATCH] drm/amd/pm: remove some useless code for vangogh Xiaojian Du
2021-02-01 8:50 ` Wang, Kevin(Yang)
2021-02-01 9:03 ` Huang Rui [this message]
2021-02-01 9:10 ` Quan, Evan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201090347.GC3140926@hr-amd \
--to=ray.huang@amd.com \
--cc=Evan.Quan@amd.com \
--cc=Kevin1.Wang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.