From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE82AC433DB for ; Mon, 1 Feb 2021 09:38:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FBB864EAE for ; Mon, 1 Feb 2021 09:38:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FBB864EAE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=antioche.eu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.79630.145003 (Exim 4.92) (envelope-from ) id 1l6Vej-0006Sm-DA; Mon, 01 Feb 2021 09:38:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 79630.145003; Mon, 01 Feb 2021 09:38:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6Vej-0006Sf-A6; Mon, 01 Feb 2021 09:38:01 +0000 Received: by outflank-mailman (input) for mailman id 79630; Mon, 01 Feb 2021 09:37:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6Veh-0006SX-Ii for xen-devel@lists.xenproject.org; Mon, 01 Feb 2021 09:37:59 +0000 Received: from chassiron.antioche.eu.org (unknown [2001:41d0:fe9d:1101::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 229d5425-a32d-4a00-bfe8-480a686f2dfe; Mon, 01 Feb 2021 09:37:56 +0000 (UTC) Received: from rochebonne.antioche.eu.org (rochebonne [10.0.0.1]) by chassiron.antioche.eu.org (8.15.2/8.15.2) with ESMTP id 1119blZa005621; Mon, 1 Feb 2021 10:37:47 +0100 (MET) Received: by rochebonne.antioche.eu.org (Postfix, from userid 1210) id 66E13281D; Mon, 1 Feb 2021 10:37:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 229d5425-a32d-4a00-bfe8-480a686f2dfe Date: Mon, 1 Feb 2021 10:37:47 +0100 From: Manuel Bouyer To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu Subject: Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD Message-ID: <20210201093747.GA624@antioche.eu.org> References: <20210130230300.11664-1-bouyer@netbsd.org> <20210130230300.11664-2-bouyer@netbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (chassiron.antioche.eu.org [151.127.5.145]); Mon, 01 Feb 2021 10:37:47 +0100 (MET) On Mon, Feb 01, 2021 at 09:21:58AM +0100, Roger Pau Monné wrote: > On Sun, Jan 31, 2021 at 12:03:00AM +0100, Manuel Bouyer wrote: > > Document that on NetBSD, the tap interface will be configured by the > > qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environnement > > variable. > > You are missing a Signed-off-by tag here ;). > > > --- > > docs/man/xl-network-configuration.5.pod | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/docs/man/xl-network-configuration.5.pod b/docs/man/xl-network-configuration.5.pod > > index af058d4d3c..f6eb6c31fc 100644 > > --- a/docs/man/xl-network-configuration.5.pod > > +++ b/docs/man/xl-network-configuration.5.pod > > @@ -172,6 +172,10 @@ add it to the relevant bridge). Defaults to > > C but can be set to any script. Some example > > scripts are installed in C. > > > > +On NetBSD, HVM guests will always use > > +C to configure the tap interface. The first argument > > +is the tap interface, the second is the bridge name. the environnement variable > > +C contains the domU's ID. > > LGTM, but I would make it even less technical and more user focused: > > Note on NetBSD HVM guests will ignore the script option for tap > (emulated) interfaces and always use C to > configure the interface in bridged mode. Well, as a user, I want to know how the scripts are called, so that I can tune them ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --