All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 1/5] ap: return error from GetDiagnostics if not started
Date: Mon, 01 Feb 2021 14:05:14 -0800	[thread overview]
Message-ID: <20210201220518.36975-1-prestwoj@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

---
 src/ap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/ap.c b/src/ap.c
index 37dd05b9..fddf0255 100644
--- a/src/ap.c
+++ b/src/ap.c
@@ -3200,6 +3200,9 @@ static struct l_dbus_message *ap_dbus_get_diagnostics(struct l_dbus *dbus,
 	struct diagnostic_data *data;
 	int ret;
 
+	if (!ap_if->ap)
+		return dbus_error_not_found(message);
+
 	data = l_new(struct diagnostic_data, 1);
 	data->pending = l_dbus_message_ref(message);
 
-- 
2.26.2

             reply	other threads:[~2021-02-01 22:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 22:05 James Prestwood [this message]
2021-02-01 22:05 ` [PATCH 2/5] client: ap: handle NotFound on diagnostic interface James Prestwood
2021-02-01 22:05 ` [PATCH 3/5] ap: add SSID property James Prestwood
2021-02-01 22:05 ` [PATCH 4/5] doc: document SSID property on AP interface James Prestwood
2021-02-01 22:21   ` Denis Kenzior
2021-02-01 22:05 ` [PATCH 5/5] client: ap: show SSID in 'ap <wlan> show' James Prestwood
2021-02-01 22:10   ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210201220518.36975-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.