From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12589C433E9 for ; Tue, 2 Feb 2021 00:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE29564ED7 for ; Tue, 2 Feb 2021 00:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbhBBAHq convert rfc822-to-8bit (ORCPT ); Mon, 1 Feb 2021 19:07:46 -0500 Received: from foss.arm.com ([217.140.110.172]:41282 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbhBBAHp (ORCPT ); Mon, 1 Feb 2021 19:07:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81173147A; Mon, 1 Feb 2021 16:06:58 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16D0F3F718; Mon, 1 Feb 2021 16:06:55 -0800 (PST) Date: Tue, 2 Feb 2021 00:05:57 +0000 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Maxime Ripard , Chen-Yu Tsai , Samuel Holland , Icenowy Zheng , Rob Herring , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Alessandro Zummo , Alexandre Belloni , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210202000557.4987de6b@slackpad.fritz.box> In-Reply-To: <1675074.8rG671tKPg@kista> References: <20210127172500.13356-1-andre.przywara@arm.com> <20210127172500.13356-13-andre.przywara@arm.com> <1675074.8rG671tKPg@kista> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Sun, 31 Jan 2021 14:44:40 +0100 Jernej Škrabec wrote: Hi Jernej, > Dne sreda, 27. januar 2021 ob 18:24:52 CET je Andre Przywara napisal(a): > > Add the obvious compatible name to the existing RTC binding, and pair > > it with the existing H6 fallback compatible string, as the devices are > > compatible. > > After close lookup I would disagree with this observation. Major difference is > that H616 doesn't support usage of external 32768 Hz oscillator. It uses 24 > MHz oscillator with divider for that case. Due to that change, whole logic for > external oscillator should go out. Additionally, this logic overwrites default > value in LOSC_CTRL register, which is not nice (there is no documentation for > those bits). Thanks for the heads up, and I wonder if there is more to that. From comparing the RTC documentation, I wonder if we should actually have incoming clocks in the bindings (the crystals / external clock sources with 32KHz, 16MHz, 24MHz). Then we could actually model which crystals the board provides. It seems like the H6 made the 32KHz OSC optional, and the H616 simply doesn't support it anymore - at the very least I don't see any X32K pins anymore. But more importantly: looking more closely (I only skimmed over the register summary back then) the actual RTC registers are different: the H616 encodes a linear day number (vs. a broken-down D-M-Y), also the time-of-day register is different. So we definitely need a driver update, and hence need to drop this patch. Cheers, Andre > Best regards, > Jernej > > > > > Signed-off-by: Andre Przywara > > Acked-by: Rob Herring > > --- > > .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31- > rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > index b1b0ee769b71..4193e5813344 100644 > > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > @@ -26,6 +26,9 @@ properties: > > - const: allwinner,sun50i-a64-rtc > > - const: allwinner,sun8i-h3-rtc > > - const: allwinner,sun50i-h6-rtc > > + - items: > > + - const: allwinner,sun50i-h616-rtc > > + - const: allwinner,sun50i-h6-rtc > > > > reg: > > maxItems: 1 > > -- > > 2.17.5 > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A50C433E0 for ; Tue, 2 Feb 2021 00:08:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8486864ED9 for ; Tue, 2 Feb 2021 00:08:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8486864ED9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BAJvPjSN0coGOfuZwGunNYfe8t/lAUcMpXBZNW9KHdw=; b=OMyaqmA/442OHdIUOUuvoWgsK 1deXtGoLod3Mb7PsReusuVYW7GD4K2UarL8nsrE/DkmUOvYzU7eybqNM7PfpqMOTBiIeUWfwn8Jkn 8O0UPCgDO6jVGVK+NpKC5iB9kgv8BaRqQsUwD9dJYJB1Oh6jmKi5VOaP7aJlWDunTIJZGJlaFOyrF tpiA9ZYRHSwHuH9gcKxq0+egsgtzOjR2C/70juElP/KQ8PbdD8eEvgbyrWStcofvXQL7oaQcEgiFD X3yavUjNePsahcAqP3yr7XTxQDUoG/3//SwyLpnjJx9wdW4tcYpodj85Ft7jv8DZFGjSvN1hCMMHb MRWeD/Bjw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6jDl-0004uB-D7; Tue, 02 Feb 2021 00:07:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6jDh-0004td-Uf for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 00:07:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81173147A; Mon, 1 Feb 2021 16:06:58 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16D0F3F718; Mon, 1 Feb 2021 16:06:55 -0800 (PST) Date: Tue, 2 Feb 2021 00:05:57 +0000 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Subject: Re: [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210202000557.4987de6b@slackpad.fritz.box> In-Reply-To: <1675074.8rG671tKPg@kista> References: <20210127172500.13356-1-andre.przywara@arm.com> <20210127172500.13356-13-andre.przywara@arm.com> <1675074.8rG671tKPg@kista> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210201_190702_148987_279F3247 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Rob Herring , Alexandre Belloni , Alessandro Zummo , Samuel Holland , Yangtao Li , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAzMSBKYW4gMjAyMSAxNDo0NDo0MCArMDEwMApKZXJuZWogxaBrcmFiZWMgPGplcm5l ai5za3JhYmVjQHNpb2wubmV0PiB3cm90ZToKCkhpIEplcm5laiwKCj4gRG5lIHNyZWRhLCAyNy4g amFudWFyIDIwMjEgb2IgMTg6MjQ6NTIgQ0VUIGplIEFuZHJlIFByenl3YXJhIG5hcGlzYWwoYSk6 Cj4gPiBBZGQgdGhlIG9idmlvdXMgY29tcGF0aWJsZSBuYW1lIHRvIHRoZSBleGlzdGluZyBSVEMg YmluZGluZywgYW5kIHBhaXIKPiA+IGl0IHdpdGggdGhlIGV4aXN0aW5nIEg2IGZhbGxiYWNrIGNv bXBhdGlibGUgc3RyaW5nLCBhcyB0aGUgZGV2aWNlcyBhcmUKPiA+IGNvbXBhdGlibGUuICAKPiAK PiBBZnRlciBjbG9zZSBsb29rdXAgSSB3b3VsZCBkaXNhZ3JlZSB3aXRoIHRoaXMgb2JzZXJ2YXRp b24uIE1ham9yIGRpZmZlcmVuY2UgaXMgCj4gdGhhdCBINjE2IGRvZXNuJ3Qgc3VwcG9ydCB1c2Fn ZSBvZiBleHRlcm5hbCAzMjc2OCBIeiBvc2NpbGxhdG9yLiBJdCB1c2VzIDI0IAo+IE1IeiBvc2Np bGxhdG9yIHdpdGggZGl2aWRlciBmb3IgdGhhdCBjYXNlLiBEdWUgdG8gdGhhdCBjaGFuZ2UsIHdo b2xlIGxvZ2ljIGZvciAKPiBleHRlcm5hbCBvc2NpbGxhdG9yIHNob3VsZCBnbyBvdXQuIEFkZGl0 aW9uYWxseSwgdGhpcyBsb2dpYyBvdmVyd3JpdGVzIGRlZmF1bHQgCj4gdmFsdWUgaW4gTE9TQ19D VFJMIHJlZ2lzdGVyLCB3aGljaCBpcyBub3QgbmljZSAodGhlcmUgaXMgbm8gZG9jdW1lbnRhdGlv biBmb3IgCj4gdGhvc2UgYml0cykuCgpUaGFua3MgZm9yIHRoZSBoZWFkcyB1cCwgYW5kIEkgd29u ZGVyIGlmIHRoZXJlIGlzIG1vcmUgdG8gdGhhdC4gRnJvbQpjb21wYXJpbmcgdGhlIFJUQyBkb2N1 bWVudGF0aW9uLCBJIHdvbmRlciBpZiB3ZSBzaG91bGQgYWN0dWFsbHkgaGF2ZQppbmNvbWluZyBj bG9ja3MgaW4gdGhlIGJpbmRpbmdzICh0aGUgY3J5c3RhbHMgLyBleHRlcm5hbCBjbG9jayBzb3Vy Y2VzCndpdGggMzJLSHosIDE2TUh6LCAyNE1IeikuIFRoZW4gd2UgY291bGQgYWN0dWFsbHkgbW9k ZWwgd2hpY2ggY3J5c3RhbHMKdGhlIGJvYXJkIHByb3ZpZGVzLiBJdCBzZWVtcyBsaWtlIHRoZSBI NiBtYWRlIHRoZSAzMktIeiBPU0Mgb3B0aW9uYWwsCmFuZCB0aGUgSDYxNiBzaW1wbHkgZG9lc24n dCBzdXBwb3J0IGl0IGFueW1vcmUgLSBhdCB0aGUgdmVyeSBsZWFzdCBJCmRvbid0IHNlZSBhbnkg WDMySyBwaW5zIGFueW1vcmUuCgpCdXQgbW9yZSBpbXBvcnRhbnRseTogbG9va2luZyBtb3JlIGNs b3NlbHkgKEkgb25seSBza2ltbWVkIG92ZXIgdGhlCnJlZ2lzdGVyIHN1bW1hcnkgYmFjayB0aGVu KSB0aGUgYWN0dWFsIFJUQyByZWdpc3RlcnMgYXJlIGRpZmZlcmVudDoKdGhlIEg2MTYgZW5jb2Rl cyBhIGxpbmVhciBkYXkgbnVtYmVyICh2cy4gYSBicm9rZW4tZG93biBELU0tWSksIGFsc28gdGhl CnRpbWUtb2YtZGF5IHJlZ2lzdGVyIGlzIGRpZmZlcmVudC4KClNvIHdlIGRlZmluaXRlbHkgbmVl ZCBhIGRyaXZlciB1cGRhdGUsIGFuZCBoZW5jZSBuZWVkIHRvIGRyb3AgdGhpcwpwYXRjaC4KCkNo ZWVycywKQW5kcmUKCj4gQmVzdCByZWdhcmRzLAo+IEplcm5lago+IAo+ID4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT4KPiA+IEFja2Vk LWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+ID4gLS0tCj4gPiAgLi4uL2Rldmlj ZXRyZWUvYmluZGluZ3MvcnRjL2FsbHdpbm5lcixzdW42aS1hMzEtcnRjLnlhbWwgICAgICAgfCAz ICsrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ydGMvYWxsd2lubmVyLHN1 bjZpLWEzMS0gIAo+IHJ0Yy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3J0Yy9hbGx3aW5uZXIsc3VuNmktYTMxLXJ0Yy55YW1sCj4gPiBpbmRleCBiMWIwZWU3NjliNzEu LjQxOTNlNTgxMzM0NCAxMDA2NDQKPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9ydGMvYWxsd2lubmVyLHN1bjZpLWEzMS1ydGMueWFtbAo+ID4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3J0Yy9hbGx3aW5uZXIsc3VuNmktYTMxLXJ0Yy55 YW1sCj4gPiBAQCAtMjYsNiArMjYsOSBAQCBwcm9wZXJ0aWVzOgo+ID4gICAgICAgICAgICAtIGNv bnN0OiBhbGx3aW5uZXIsc3VuNTBpLWE2NC1ydGMKPiA+ICAgICAgICAgICAgLSBjb25zdDogYWxs d2lubmVyLHN1bjhpLWgzLXJ0Ywo+ID4gICAgICAgIC0gY29uc3Q6IGFsbHdpbm5lcixzdW41MGkt aDYtcnRjCj4gPiArICAgICAgLSBpdGVtczoKPiA+ICsgICAgICAgICAgLSBjb25zdDogYWxsd2lu bmVyLHN1bjUwaS1oNjE2LXJ0Ywo+ID4gKyAgICAgICAgICAtIGNvbnN0OiBhbGx3aW5uZXIsc3Vu NTBpLWg2LXJ0Ywo+ID4gIAo+ID4gICAgcmVnOgo+ID4gICAgICBtYXhJdGVtczogMQo+ID4gLS0g Cj4gPiAyLjE3LjUKPiA+IAo+ID4gICAKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==