All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Subject: [PATCH] generic/095: don't silence fio error output
Date: Tue,  2 Feb 2021 14:22:53 +0800	[thread overview]
Message-ID: <20210202062253.24478-1-zlang@redhat.com> (raw)

This case print both fio stdout and stderr to .full file, that cause
we miss some unexpected failures when there's a bug. For example:

  file:io_u.c:1803, func=io_u error, error=Block device required

This's an regression issue we find on a downstream kernel, not in
upstream. So release unexpected fio error output to find more issues.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 tests/generic/095 | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/generic/095 b/tests/generic/095
index 9afaa761..30fe77a5 100755
--- a/tests/generic/095
+++ b/tests/generic/095
@@ -98,8 +98,11 @@ _require_fio $fio_config
 _scratch_mkfs >>$seqres.full 2>&1
 _scratch_mount
 
+# There's a known EIO failure to report collisions between directio and buffered
+# writes to userspace, refer to upstream linux 5a9d929d6e13. So ignore EIO error
+# at here.
+$FIO_PROG $fio_config --ignore_error=,EIO --output=$seqres.full
 echo "Silence is golden"
-$FIO_PROG $fio_config >>$seqres.full 2>&1
 
 # xfs generates WARNINGs on purpose when applications mix buffered/mmap IO with
 # direct IO on the same file. On the other hand, this fio job has been proven
-- 
2.29.2


             reply	other threads:[~2021-02-02  6:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  6:22 Zorro Lang [this message]
2021-02-03 16:22 ` [PATCH] generic/095: don't silence fio error output Brian Foster
2021-03-14 11:36 ` Eryu Guan
2021-03-14 15:49   ` Zorro Lang
2021-03-14 16:02     ` Eryu Guan
2021-03-15  0:56       ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202062253.24478-1-zlang@redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.