All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hillf Danton <hdanton@sina.com>, Sasha Levin <sashal@kernel.org>,
	Archie Pusaka <apusaka@chromium.org>
Cc: syzbot <syzbot+3ed6361bf59830ca9138@syzkaller.appspotmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Miao-chen Chou <mcchou@chromium.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@intel.com>,
	syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: slab-out-of-bounds Read in add_adv_patterns_monitor
Date: Tue, 2 Feb 2021 11:10:10 +0300	[thread overview]
Message-ID: <20210202081010.GZ20820@kadam> (raw)
In-Reply-To: <20210202075110.GR2696@kadam>

Commit 36211f7fc1e7 ("Bluetooth: Pause service discovery for suspend")
seems like a bugfix as well but there is no Fixes tag there either.  The
commit message should be more clear what the effect of the bug looks
like to the user.  I like to write something like this:

[PATCH] Bluetooth: Pause service discovery for suspend

Just like MGMT_OP_START_DISCOVERY, we should reject
MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused
for suspend.  This bug was discovered by auditing the software and no
one has complained about it, but presumably it leads to a hanged process
because the cmd cannot complete.

Sometimes it's hard to know what the affect of a bug is, but since
you're working in the subsystem then you probably have a better guess
than the rest of us so even a guess is useful.

regards,
dan carpenter


  reply	other threads:[~2021-02-02  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 17:08 KASAN: slab-out-of-bounds Read in add_adv_patterns_monitor syzbot
     [not found] ` <20210131100154.14452-1-hdanton@sina.com>
2021-02-02  7:51   ` Dan Carpenter
2021-02-02  8:10     ` Dan Carpenter [this message]
2021-03-20  8:27 ` [syzbot] " syzbot
2022-05-12 13:04   ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202081010.GZ20820@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=apusaka@chromium.org \
    --cc=hdanton@sina.com \
    --cc=johan.hedberg@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mcchou@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=syzbot+3ed6361bf59830ca9138@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.