From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC98C433DB for ; Tue, 2 Feb 2021 09:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65EBE64D99 for ; Tue, 2 Feb 2021 09:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbhBBJjE (ORCPT ); Tue, 2 Feb 2021 04:39:04 -0500 Received: from verein.lst.de ([213.95.11.211]:45102 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233084AbhBBJgq (ORCPT ); Tue, 2 Feb 2021 04:36:46 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id C6E0F68CEC; Tue, 2 Feb 2021 10:36:03 +0100 (CET) Date: Tue, 2 Feb 2021 10:36:02 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Cc: linux-block@vger.kernel.org, paolo.valente@linaro.org, axboe@kernel.dk, rostedt@goodmis.org, mingo@redhat.com, johannes.thumshirn@wdc.com, damien.lemoal@wdc.com, bvanassche@acm.org, dongli.zhang@oracle.com, akpm@linux-foundation.org, aravind.ramesh@wdc.com, joshi.k@samsung.com, niklas.cassel@wdc.com, hare@suse.de, colyli@suse.de, tj@kernel.org, rdunlap@infradead.org, jack@suse.cz, hch@lst.de Subject: Re: [PATCH 5/7] block: get rid of the trace rq insert wrapper Message-ID: <20210202093602.GE17771@lst.de> References: <20210202052544.4108-1-chaitanya.kulkarni@wdc.com> <20210202052544.4108-14-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202052544.4108-14-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Feb 01, 2021 at 09:25:42PM -0800, Chaitanya Kulkarni wrote: > Get rid of the wrapper for trace_block_rq_insert() and call the function > directly. The placement of the EXPORT_TRACEPOINT_SYMBOL_GPL looks very strange, I'd keep it with the other EXPORT_TRACEPOINT_SYMBOL_GPL instances in blk-core.c. Otherwise this looks good: Reviewed-by: Christoph Hellwig