From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F514C433DB for ; Tue, 2 Feb 2021 11:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB9EB64D87 for ; Tue, 2 Feb 2021 11:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231282AbhBBLgV (ORCPT ); Tue, 2 Feb 2021 06:36:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:59592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhBBLfI (ORCPT ); Tue, 2 Feb 2021 06:35:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC32464E9B; Tue, 2 Feb 2021 11:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612265666; bh=iQZjdrytDnYe4+JE2zLjRm1WSmA5jVNSNUrdiPWQqaA=; h=Date:From:To:Cc:Subject:From; b=eA1YvFBH617s0j/ZHp9BrVaGBQse3Roq/akpIFgO8h4YK7KAtGXqfn+8F30qXEGn7 P3fVr3ENGAQ4m9QgKtpkUPG4jrbeBxRwk7RTtuxPmir9B4L60SU088ooeP6orMQHDu Spuos6n/rMOJ8jJtTVDIgcik1eTfAqlgK9b0v8LRuK6tRytdQ4aUfUVyJ+18iaAhoh FGJe5MlorJAi0JzgkEjW89Rh17W/sNrttGvuWEjyOLa8x+94QTjk8A/f3kJhKLkBt2 R3ftH5ewKRfAoHATLdIPutAS0p0/+FYXfweTB/hYQNJvVly/Qpi0aaRKGr5gaxG5zN PN6NIwhGI3Lbw== Date: Tue, 2 Feb 2021 05:34:23 -0600 From: "Gustavo A. R. Silva" To: Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [REPORT][next] pinctrl: pinctrl-microchip-sgpio: out-of-bounds bug in sgpio_clrsetbits() Message-ID: <20210202113423.GA277746@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi, While addressing some out-of-bounds warnings, I found the following bug: drivers/pinctrl/pinctrl-microchip-sgpio.c:154:57: warning: array subscript 10 is above array bounds of ‘const u8[10]’ {aka ‘const unsigned char[10]’} [-Warray-bounds] The bug was introduced by commit be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for sparx5)"): 575 sgpio_clrsetbits(bank->priv, REG_INT_TRIGGER + SGPIO_MAX_BITS, addr.bit, 576 BIT(addr.port), (!!(type & 0x2)) << addr.port); REG_INT_TRIGGER + SGPIO_MAX_BITS turns out to be 10, which is outside the boundaries of priv->properties->regoff[] at line 154: 151 static inline void sgpio_clrsetbits(struct sgpio_priv *priv, 152 u32 rno, u32 off, u32 clear, u32 set) 153 { 154 u32 __iomem *reg = &priv->regs[priv->properties->regoff[rno] + off]; 155 u32 val = readl(reg); 156 157 val &= ~clear; 158 val |= set; 159 160 writel(val, reg); 161 } because priv->properties->regoff[] is an array of MAXREG elements, with MAXREG representing the value of 10 in the following enum: 28 enum { 29 REG_INPUT_DATA, 30 REG_PORT_CONFIG, 31 REG_PORT_ENABLE, 32 REG_SIO_CONFIG, 33 REG_SIO_CLOCK, 34 REG_INT_POLARITY, 35 REG_INT_TRIGGER, 36 REG_INT_ACK, 37 REG_INT_ENABLE, 38 REG_INT_IDENT, 39 MAXREG 40 }; 52 struct sgpio_properties { 53 int arch; 54 int flags; 55 u8 regoff[MAXREG]; 56 }; Thanks -- Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F13EC433E0 for ; Tue, 2 Feb 2021 11:35:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4A6F64EC1 for ; Tue, 2 Feb 2021 11:35:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4A6F64EC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=eHsvMbXuO5rZKeHgBYys2H0j/C/FgWNimA4OZwV86Ys=; b=Xwi1xoYP2ZJAO0ch4Vo3IfE3nn sMBBmVU04te9cfmv8+akfaWTb39AqDSbG816OfSmOAKs3hWcAoDMFvN9GmZh0jUhsmNOCC8dNYF3S HSgz31ukJ3cIZjCCFsaBSz2xGnpwnlliC5jIcsNNzOVya1BhvkL1DbNPlc+BpWDRa4DKMP2RebsPw 3uSQAIhy1QGgrfmYUDJwN8q5bU3fIWKlbyKCE0fGmh9KoFowy3vY80SxbAfB3p8plsGks8xCU9U4f Tyzy4kzc5z3ufCp4g2T00cc1lf5SlcmnD7ZL2SxUu5kucoa4kb+qY/Rw2njmR5i6GzHk/Q80Mlker 1iMoxguQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6tx0-0005fq-S0; Tue, 02 Feb 2021 11:34:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6twy-0005fQ-6I for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 11:34:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC32464E9B; Tue, 2 Feb 2021 11:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612265666; bh=iQZjdrytDnYe4+JE2zLjRm1WSmA5jVNSNUrdiPWQqaA=; h=Date:From:To:Cc:Subject:From; b=eA1YvFBH617s0j/ZHp9BrVaGBQse3Roq/akpIFgO8h4YK7KAtGXqfn+8F30qXEGn7 P3fVr3ENGAQ4m9QgKtpkUPG4jrbeBxRwk7RTtuxPmir9B4L60SU088ooeP6orMQHDu Spuos6n/rMOJ8jJtTVDIgcik1eTfAqlgK9b0v8LRuK6tRytdQ4aUfUVyJ+18iaAhoh FGJe5MlorJAi0JzgkEjW89Rh17W/sNrttGvuWEjyOLa8x+94QTjk8A/f3kJhKLkBt2 R3ftH5ewKRfAoHATLdIPutAS0p0/+FYXfweTB/hYQNJvVly/Qpi0aaRKGr5gaxG5zN PN6NIwhGI3Lbw== Date: Tue, 2 Feb 2021 05:34:23 -0600 From: "Gustavo A. R. Silva" To: Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Linus Walleij Subject: [REPORT][next] pinctrl: pinctrl-microchip-sgpio: out-of-bounds bug in sgpio_clrsetbits() Message-ID: <20210202113423.GA277746@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_063428_389374_E7AAEEF1 X-CRM114-Status: UNSURE ( 7.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpXaGlsZSBhZGRyZXNzaW5nIHNvbWUgb3V0LW9mLWJvdW5kcyB3YXJuaW5ncywgSSBmb3Vu ZCB0aGUgZm9sbG93aW5nIGJ1ZzoKCmRyaXZlcnMvcGluY3RybC9waW5jdHJsLW1pY3JvY2hpcC1z Z3Bpby5jOjE1NDo1Nzogd2FybmluZzogYXJyYXkgc3Vic2NyaXB0IDEwIGlzIGFib3ZlIGFycmF5 IGJvdW5kcyBvZiDigJhjb25zdCB1OFsxMF3igJkge2FrYSDigJhjb25zdCB1bnNpZ25lZCBjaGFy WzEwXeKAmX0gWy1XYXJyYXktYm91bmRzXQoKVGhlIGJ1ZyB3YXMgaW50cm9kdWNlZCBieSBjb21t aXQgYmUyZGM4NTlhYmQ0ICgicGluY3RybDogcGluY3RybC1taWNyb2NoaXAtc2dwaW86IEFkZCBp cnEgc3VwcG9ydCAoZm9yIHNwYXJ4NSkiKToKCjU3NSAgICAgICAgIHNncGlvX2NscnNldGJpdHMo YmFuay0+cHJpdiwgUkVHX0lOVF9UUklHR0VSICsgU0dQSU9fTUFYX0JJVFMsIGFkZHIuYml0LAo1 NzYgICAgICAgICAgICAgICAgICAgICAgICAgIEJJVChhZGRyLnBvcnQpLCAoISEodHlwZSAmIDB4 MikpIDw8IGFkZHIucG9ydCk7CgpSRUdfSU5UX1RSSUdHRVIgKyBTR1BJT19NQVhfQklUUyB0dXJu cyBvdXQgdG8gYmUgMTAsIHdoaWNoIGlzIG91dHNpZGUgdGhlIGJvdW5kYXJpZXMKb2YgcHJpdi0+ cHJvcGVydGllcy0+cmVnb2ZmW10gYXQgbGluZSAxNTQ6CgoxNTEgc3RhdGljIGlubGluZSB2b2lk IHNncGlvX2NscnNldGJpdHMoc3RydWN0IHNncGlvX3ByaXYgKnByaXYsICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAoxNTIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdTMyIHJubywgdTMyIG9mZiwgdTMyIGNsZWFyLCB1MzIgc2V0KSAgICAgICAgICAg ICAgICAgICAgICAgICAgIAoxNTMgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIAoxNTQgICAgICAgICB1MzIgX19pb21lbSAqcmVnID0gJnByaXYtPnJlZ3NbcHJpdi0+ cHJvcGVydGllcy0+cmVnb2ZmW3Jub10gKyBvZmZdOyAgICAgICAgICAgICAgICAgICAgICAgIAox NTUgICAgICAgICB1MzIgdmFsID0gcmVhZGwocmVnKTsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAoxNTYgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAoxNTcgICAgICAgICB2YWwgJj0g fmNsZWFyOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIAoxNTggICAgICAgICB2YWwgfD0gc2V0OyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIAoxNTkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIAoxNjAgICAgICAgICB3cml0ZWwodmFsLCByZWcpOyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAoxNjEgfQoKYmVjYXVzZSBwcml2LT5wcm9wZXJ0aWVzLT5yZWdvZmZbXSBpcyBhbiBhcnJheSBv ZiBNQVhSRUcgZWxlbWVudHMsIHdpdGggTUFYUkVHCnJlcHJlc2VudGluZyB0aGUgdmFsdWUgb2Yg MTAgaW4gdGhlIGZvbGxvd2luZyBlbnVtOgoKIDI4IGVudW0geyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAKIDI5ICAgICAgICAgUkVHX0lOUFVUX0RBVEEsICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAKIDMwICAgICAgICAgUkVHX1BPUlRfQ09ORklHLCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAK IDMxICAgICAgICAgUkVHX1BPUlRfRU5BQkxFLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDMyICAgICAg ICAgUkVHX1NJT19DT05GSUcsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDMzICAgICAgICAgUkVHX1NJ T19DTE9DSywgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDM0ICAgICAgICAgUkVHX0lOVF9QT0xBUklU WSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAKIDM1ICAgICAgICAgUkVHX0lOVF9UUklHR0VSLCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAKIDM2ICAgICAgICAgUkVHX0lOVF9BQ0ssICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKIDM3ICAgICAgICAgUkVHX0lOVF9FTkFCTEUsICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDM4ICAg ICAgICAgUkVHX0lOVF9JREVOVCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDM5ICAgICAgICAgTUFY UkVHICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIDQwIH07CgogNTIgc3RydWN0IHNncGlv X3Byb3BlcnRpZXMgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogNTMgICAgICAgICBpbnQgYXJjaDsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIAogNTQgICAgICAgICBpbnQgZmxhZ3M7ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAogNTUgICAgICAgICB1OCByZWdvZmZbTUFYUkVHXTsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAogNTYgfTsKClRoYW5rcwotLQpHdXN0YXZvCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==