From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries
Date: Wed, 03 Feb 2021 00:16:49 +0800 [thread overview]
Message-ID: <202102030033.SNlpq61K-lkp@intel.com> (raw)
In-Reply-To: <20210202091116.196134-3-aneesh.kumar@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 5768 bytes --]
Hi "Aneesh,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on kselftest/next]
[also build test WARNING on powerpc/next v5.11-rc6 next-20210125]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/selftest-mremap_test-Update-the-test-to-handle-pagesize-other-than-4K/20210202-173010
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: i386-randconfig-s001-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
# https://github.com/0day-ci/linux/commit/e3237cf6d75a40d5736e26dc623b34e9a89cfdc9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aneesh-Kumar-K-V/selftest-mremap_test-Update-the-test-to-handle-pagesize-other-than-4K/20210202-173010
git checkout e3237cf6d75a40d5736e26dc623b34e9a89cfdc9
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
mm/mremap.c: In function 'move_normal_pud':
>> mm/mremap.c:286:8: warning: variable 'pud' set but not used [-Wunused-but-set-variable]
286 | pud_t pud;
| ^~~
vim +/pud +286 mm/mremap.c
2c91bd4a4e2e53 Joel Fernandes (Google 2019-01-03 279)
c49dd340180260 Kalesh Singh 2020-12-14 280 #ifdef CONFIG_HAVE_MOVE_PUD
c49dd340180260 Kalesh Singh 2020-12-14 281 static bool move_normal_pud(struct vm_area_struct *vma, unsigned long old_addr,
c49dd340180260 Kalesh Singh 2020-12-14 282 unsigned long new_addr, pud_t *old_pud, pud_t *new_pud)
c49dd340180260 Kalesh Singh 2020-12-14 283 {
c49dd340180260 Kalesh Singh 2020-12-14 284 spinlock_t *old_ptl, *new_ptl;
c49dd340180260 Kalesh Singh 2020-12-14 285 struct mm_struct *mm = vma->vm_mm;
c49dd340180260 Kalesh Singh 2020-12-14 @286 pud_t pud;
c49dd340180260 Kalesh Singh 2020-12-14 287
c49dd340180260 Kalesh Singh 2020-12-14 288 /*
c49dd340180260 Kalesh Singh 2020-12-14 289 * The destination pud shouldn't be established, free_pgtables()
c49dd340180260 Kalesh Singh 2020-12-14 290 * should have released it.
c49dd340180260 Kalesh Singh 2020-12-14 291 */
c49dd340180260 Kalesh Singh 2020-12-14 292 if (WARN_ON_ONCE(!pud_none(*new_pud)))
c49dd340180260 Kalesh Singh 2020-12-14 293 return false;
c49dd340180260 Kalesh Singh 2020-12-14 294
c49dd340180260 Kalesh Singh 2020-12-14 295 /*
c49dd340180260 Kalesh Singh 2020-12-14 296 * We don't have to worry about the ordering of src and dst
c49dd340180260 Kalesh Singh 2020-12-14 297 * ptlocks because exclusive mmap_lock prevents deadlock.
c49dd340180260 Kalesh Singh 2020-12-14 298 */
c49dd340180260 Kalesh Singh 2020-12-14 299 old_ptl = pud_lock(vma->vm_mm, old_pud);
c49dd340180260 Kalesh Singh 2020-12-14 300 new_ptl = pud_lockptr(mm, new_pud);
c49dd340180260 Kalesh Singh 2020-12-14 301 if (new_ptl != old_ptl)
c49dd340180260 Kalesh Singh 2020-12-14 302 spin_lock_nested(new_ptl, SINGLE_DEPTH_NESTING);
c49dd340180260 Kalesh Singh 2020-12-14 303
c49dd340180260 Kalesh Singh 2020-12-14 304 /* Clear the pud */
c49dd340180260 Kalesh Singh 2020-12-14 305 pud = *old_pud;
c49dd340180260 Kalesh Singh 2020-12-14 306 pud_clear(old_pud);
c49dd340180260 Kalesh Singh 2020-12-14 307
c49dd340180260 Kalesh Singh 2020-12-14 308 VM_BUG_ON(!pud_none(*new_pud));
c49dd340180260 Kalesh Singh 2020-12-14 309
e3237cf6d75a40 Aneesh Kumar K.V 2021-02-02 310 pud_populate(mm, new_pud, (pmd_t *)pud_page_vaddr(pud));
c49dd340180260 Kalesh Singh 2020-12-14 311 flush_tlb_range(vma, old_addr, old_addr + PUD_SIZE);
c49dd340180260 Kalesh Singh 2020-12-14 312 if (new_ptl != old_ptl)
c49dd340180260 Kalesh Singh 2020-12-14 313 spin_unlock(new_ptl);
c49dd340180260 Kalesh Singh 2020-12-14 314 spin_unlock(old_ptl);
c49dd340180260 Kalesh Singh 2020-12-14 315
c49dd340180260 Kalesh Singh 2020-12-14 316 return true;
c49dd340180260 Kalesh Singh 2020-12-14 317 }
c49dd340180260 Kalesh Singh 2020-12-14 318 #else
c49dd340180260 Kalesh Singh 2020-12-14 319 static inline bool move_normal_pud(struct vm_area_struct *vma,
c49dd340180260 Kalesh Singh 2020-12-14 320 unsigned long old_addr, unsigned long new_addr, pud_t *old_pud,
c49dd340180260 Kalesh Singh 2020-12-14 321 pud_t *new_pud)
c49dd340180260 Kalesh Singh 2020-12-14 322 {
c49dd340180260 Kalesh Singh 2020-12-14 323 return false;
c49dd340180260 Kalesh Singh 2020-12-14 324 }
c49dd340180260 Kalesh Singh 2020-12-14 325 #endif
c49dd340180260 Kalesh Singh 2020-12-14 326
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35518 bytes --]
next prev parent reply other threads:[~2021-02-02 16:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 9:11 [RFC PATCH 1/6] selftest/mremap_test: Update the test to handle pagesize other than 4K Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 2/6] selftest/mremap_test: Avoid crash with static build Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 10:47 ` Peter Zijlstra
2021-02-02 10:47 ` Peter Zijlstra
2021-02-02 14:50 ` Aneesh Kumar K.V
2021-02-02 14:50 ` Aneesh Kumar K.V
2021-02-02 16:16 ` kernel test robot [this message]
2021-02-02 9:11 ` [RFC PATCH 4/6] mm/mremap: Use mmu gather interface instead of flush_tlb_range Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 5/6] mm/mremap: Allow arch runtime override Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 9:11 ` [RFC PATCH 6/6] powerpc/mm: Enable move pmd/pud Aneesh Kumar K.V
2021-02-02 9:11 ` Aneesh Kumar K.V
2021-02-02 13:29 ` [RFC PATCH 1/6] selftest/mremap_test: Update the test to handle pagesize other than 4K Li Xinhai
2021-02-02 13:29 ` Li Xinhai
2021-02-02 14:51 ` Aneesh Kumar K.V
2021-02-02 14:51 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102030033.SNlpq61K-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.