Re: [PATCH v5 2/2] media: i2c: Add imx334 camera sensor driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5098 bytes --]

Hi Martina,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on fd821bf0ed9a7db09d2e007df697f4d9ecfda99a]

url:    https://github.com/0day-ci/linux/commits/Martina-Krasteva/IMX334-Camera-Sensor-Driver/20210202-094552
base:   fd821bf0ed9a7db09d2e007df697f4d9ecfda99a
config: arm-randconfig-r026-20210202 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/57bf371289c42fe7cc648f2de6cd6680df675f09
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Martina-Krasteva/IMX334-Camera-Sensor-Driver/20210202-094552
        git checkout 57bf371289c42fe7cc648f2de6cd6680df675f09
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/imx334.c:751:5: warning: no previous prototype for function 'imx334_parse_hw_config' [-Wmissing-prototypes]
   int imx334_parse_hw_config(struct imx334 *imx334)
       ^
   drivers/media/i2c/imx334.c:751:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int imx334_parse_hw_config(struct imx334 *imx334)
   ^
   static 
>> drivers/media/i2c/imx334.c:769:55: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
                   dev_err(imx334->dev, "failed to get reset gpio %d", ret);
                                                                       ^~~
   include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
           _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                         ^~~~~~~~~~~
   drivers/media/i2c/imx334.c:759:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   2 warnings generated.


vim +/imx334_parse_hw_config +751 drivers/media/i2c/imx334.c

   744	
   745	/**
   746	 * imx334_parse_hw_config() - Parse HW configuration and check if supported
   747	 * @imx334: pointer to imx334 device
   748	 *
   749	 * Return: 0 if successful, error code otherwise.
   750	 */
 > 751	int imx334_parse_hw_config(struct imx334 *imx334)
   752	{
   753		struct fwnode_handle *fwnode = dev_fwnode(imx334->dev);
   754		struct v4l2_fwnode_endpoint bus_cfg = {
   755			.bus_type = V4L2_MBUS_CSI2_DPHY
   756		};
   757		struct fwnode_handle *ep;
   758		unsigned long rate;
   759		int ret;
   760		int i;
   761	
   762		if (!fwnode)
   763			return -ENXIO;
   764	
   765		/* Request optional reset pin */
   766		imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset",
   767							     GPIOD_OUT_LOW);
   768		if (IS_ERR(imx334->reset_gpio)) {
 > 769			dev_err(imx334->dev, "failed to get reset gpio %d", ret);
   770			return PTR_ERR(imx334->reset_gpio);
   771		}
   772	
   773		/* Get sensor input clock */
   774		imx334->inclk = devm_clk_get(imx334->dev, "inclk");
   775		if (IS_ERR(imx334->inclk)) {
   776			dev_err(imx334->dev, "could not get inclk");
   777			return PTR_ERR(imx334->inclk);
   778		}
   779	
   780		rate = clk_get_rate(imx334->inclk);
   781		if (rate != IMX334_INCLK_RATE) {
   782			dev_err(imx334->dev, "inclk frequency mismatch");
   783			return -EINVAL;
   784		}
   785	
   786		ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
   787		if (!ep)
   788			return -ENXIO;
   789	
   790		ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
   791		fwnode_handle_put(ep);
   792		if (ret)
   793			return ret;
   794	
   795		if (bus_cfg.bus.mipi_csi2.num_data_lanes != IMX334_NUM_DATA_LANES) {
   796			dev_err(imx334->dev,
   797				"number of CSI2 data lanes %d is not supported",
   798				bus_cfg.bus.mipi_csi2.num_data_lanes);
   799			ret = -EINVAL;
   800			goto done_endpoint_free;
   801		}
   802	
   803		if (!bus_cfg.nr_of_link_frequencies) {
   804			dev_err(imx334->dev, "no link frequencies defined");
   805			ret = -EINVAL;
   806			goto done_endpoint_free;
   807		}
   808	
   809		for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++)
   810			if (bus_cfg.link_frequencies[i] == IMX334_LINK_FREQ)
   811				goto done_endpoint_free;
   812	
   813		ret = -EINVAL;
   814	
   815	done_endpoint_free:
   816		v4l2_fwnode_endpoint_free(&bus_cfg);
   817	
   818		return ret;
   819	}
   820	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39972 bytes --]