All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v12 13/14] mm/vmalloc: Hugepage vmalloc mappings
Date: Wed, 03 Feb 2021 12:26:37 +0800	[thread overview]
Message-ID: <202102031255.KNFXeiw2-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3968 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210202110515.3575274-14-npiggin@gmail.com>
References: <20210202110515.3575274-14-npiggin@gmail.com>
TO: Nicholas Piggin <npiggin@gmail.com>
TO: linux-mm(a)kvack.org
TO: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Nicholas Piggin <npiggin@gmail.com>
CC: linux-kernel(a)vger.kernel.org
CC: linux-arch(a)vger.kernel.org
CC: linuxppc-dev(a)lists.ozlabs.org
CC: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
CC: Christoph Hellwig <hch@infradead.org>
CC: Christophe Leroy <christophe.leroy@csgroup.eu>

Hi Nicholas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on arm64/for-next/core v5.11-rc6]
[cannot apply to hnaz-linux-mm/master next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20210202-190833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
config: x86_64-randconfig-m001-20210202 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
mm/vmalloc.c:520 vmap_small_pages_range_noflush() warn: bitwise AND condition is false here
mm/vmalloc.c:2933 __vmalloc_node_range() error: uninitialized symbol 'area'.

vim +520 mm/vmalloc.c

c2febafc67734a Kirill A. Shutemov 2017-03-09  498  
2362efe9169e3d Nicholas Piggin    2021-02-02  499  static int vmap_small_pages_range_noflush(unsigned long addr, unsigned long end,
db64fe02258f15 Nick Piggin        2008-10-18  500  		pgprot_t prot, struct page **pages)
^1da177e4c3f41 Linus Torvalds     2005-04-16  501  {
2ba3e6947aed9b Joerg Roedel       2020-06-01  502  	unsigned long start = addr;
b521c43f58e523 Christoph Hellwig  2020-06-01  503  	pgd_t *pgd;
2362efe9169e3d Nicholas Piggin    2021-02-02  504  	unsigned long next;
db64fe02258f15 Nick Piggin        2008-10-18  505  	int err = 0;
db64fe02258f15 Nick Piggin        2008-10-18  506  	int nr = 0;
2ba3e6947aed9b Joerg Roedel       2020-06-01  507  	pgtbl_mod_mask mask = 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  508  
^1da177e4c3f41 Linus Torvalds     2005-04-16  509  	BUG_ON(addr >= end);
^1da177e4c3f41 Linus Torvalds     2005-04-16  510  	pgd = pgd_offset_k(addr);
^1da177e4c3f41 Linus Torvalds     2005-04-16  511  	do {
^1da177e4c3f41 Linus Torvalds     2005-04-16  512  		next = pgd_addr_end(addr, end);
2ba3e6947aed9b Joerg Roedel       2020-06-01  513  		if (pgd_bad(*pgd))
2ba3e6947aed9b Joerg Roedel       2020-06-01  514  			mask |= PGTBL_PGD_MODIFIED;
2ef69bb78a3fb7 Nicholas Piggin    2021-02-02  515  		err = vmap_pages_p4d_range(pgd, addr, next, prot, pages, &nr, &mask);
^1da177e4c3f41 Linus Torvalds     2005-04-16  516  		if (err)
bf88c8c83e4425 Figo.zhang         2009-09-21  517  			return err;
^1da177e4c3f41 Linus Torvalds     2005-04-16  518  	} while (pgd++, addr = next, addr != end);
db64fe02258f15 Nick Piggin        2008-10-18  519  
2ba3e6947aed9b Joerg Roedel       2020-06-01 @520  	if (mask & ARCH_PAGE_TABLE_SYNC_MASK)
2ba3e6947aed9b Joerg Roedel       2020-06-01  521  		arch_sync_kernel_mappings(start, end);
2ba3e6947aed9b Joerg Roedel       2020-06-01  522  
60bb44652a0dcc Christoph Hellwig  2020-06-01  523  	return 0;
^1da177e4c3f41 Linus Torvalds     2005-04-16  524  }
^1da177e4c3f41 Linus Torvalds     2005-04-16  525  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33984 bytes --]

             reply	other threads:[~2021-02-03  4:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  4:26 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-02 11:05 [PATCH v12 00/14] huge vmalloc mappings Nicholas Piggin
2021-02-02 11:05 ` [PATCH v12 13/14] mm/vmalloc: Hugepage " Nicholas Piggin
2021-02-02 11:05   ` Nicholas Piggin
2021-02-19  3:45   ` Ding Tianhong
2021-02-19  3:45     ` Ding Tianhong
2021-02-19  7:45     ` Nicholas Piggin
2021-02-19  7:45       ` Nicholas Piggin
2021-02-19  8:52       ` Ding Tianhong
2021-02-19  8:52         ` Ding Tianhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102031255.KNFXeiw2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.