From: Frederic Weisbecker <frederic@kernel.org>
To: chenshiyan <chenshiyan@linux.alibaba.com>
Cc: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] nohz: Restart tick before do softirq
Date: Wed, 3 Feb 2021 14:11:05 +0100 [thread overview]
Message-ID: <20210203131105.GA3666@lothringen> (raw)
In-Reply-To: <B2A33260-1D22-4C29-9811-64F0A68F0D64@linux.alibaba.com>
On Wed, Feb 03, 2021 at 09:04:05PM +0800, chenshiyan wrote:
> Are you working on an architecture that doesn't implement it?
> -No, we test it on x86.
>
> The problem is , when it's doing softirq, but there’s no tick, so we don’t know how long
> It takes. The TOP or some other procs can not show the right value of sirq.
But IRQTIME counting is based on sched_clock() which shouldn't use jiffies
in the case in x86. In fact jiffies based sched_clock() isn't suitable for
IRQTIME at all. So I don't understand the problem.
prev parent reply other threads:[~2021-02-03 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 3:45 [PATCH RESEND] nohz: Restart tick before do softirq chenshiyan
2021-02-01 12:38 ` Frederic Weisbecker
2021-02-03 13:04 ` chenshiyan
2021-02-03 13:11 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203131105.GA3666@lothringen \
--to=frederic@kernel.org \
--cc=chenshiyan@linux.alibaba.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.