From: Christoph Paasch <cpaasch at apple.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp-net] mptcp: init mptcp request socket earlier
Date: Wed, 03 Feb 2021 09:26:20 -0800 [thread overview]
Message-ID: <20210203172620.GG43803@MacBook-Pro.local> (raw)
In-Reply-To: f512d230984510ab2ccbc4e778da4474bd2e1078.1612367293.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On 02/03/21 - 17:28, Paolo Abeni wrote:
> The mptcp subflow route_req() callback performs the subflow
> req initialization after the route_req() check. If the latter
> fails, mptcp-specific bits of the current request sockets
> are left uninitialized.
>
> The above causes bad things at req socket disposal time, when
> the mptcp resources are cleared.
>
> This change addresses the issue by splitting subflow_init_req()
> into the actual initialization and the mptcp-specific checks.
> The initialization is moved before any possibly failing check.
>
> Reported-by: Christoph Paasch <cpaasch(a)apple.com>
> Fixes: 7ea851d19b23 ("tcp: merge 'init_req' and 'route_req' functions")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
> Should fix issues/125 && 130. Even syzkaller would proof the
> opposite, the problem described above looks real.
> @Christoph: could you please... ? (additional free coffee for your
> upcoming holiday in Tuscany ;)
Looking forward to the coffee!!! :-) I hope coffee translates to red wine
later in the day!
Christoph
reply other threads:[~2021-02-03 17:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203172620.GG43803@MacBook-Pro.local \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.