From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] board/orangepi-zero-plus2: switch to GPT for PARTLABEL support
Date: Wed, 3 Feb 2021 23:15:11 +0100 [thread overview]
Message-ID: <20210203221511.GO2384@scaer> (raw)
In-Reply-To: <20210203195719.519992-1-geomatsi@gmail.com>
Sergey, All,
On 2021-02-03 22:57 +0300, Sergey Matyukevich spake thusly:
> Patch that pins mmc indexes was not accepted to mainline kernel. Drop that
> patch and switch to GPT to use partition labels. For GPT the name of the
> partition in genimage.cfg is used as the label for that partition. Note
> that the default GPT partition table location conflicts with the SPL
> location, so move GPT table after bootloaders.
Applied to master, thanks, but see a very minor not, below...
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
[--SNIP--]
> diff --git a/board/orangepi/orangepi-zero-plus2/genimage.cfg b/board/orangepi/orangepi-zero-plus2/genimage.cfg
> index 8091edad6f..29377bf149 100644
> --- a/board/orangepi/orangepi-zero-plus2/genimage.cfg
> +++ b/board/orangepi/orangepi-zero-plus2/genimage.cfg
[--SNIP--]
> @@ -32,8 +36,11 @@ image sdcard.img {
> image = "boot.vfat"
> }
>
> + # 'rootfs' will be used as the partition label, used
> + # with root=PARTLABEL=rootfs kernel commadn line
Aha! You even copied my typo! ;-)
Fixed when applying.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-02-03 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 19:57 [Buildroot] [PATCH 1/1] board/orangepi-zero-plus2: switch to GPT for PARTLABEL support Sergey Matyukevich
2021-02-03 22:15 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203221511.GO2384@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.