From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc: Jeff Layton <jlayton@poochiereds.net>,
Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrei Vagin <avagin@gmail.com>
Subject: Re: [PATCH] fcntl: make F_GETOWN(EX) return 0 on dead owner task
Date: Thu, 4 Feb 2021 01:17:26 +0300 [thread overview]
Message-ID: <20210203221726.GF2172@grain> (raw)
In-Reply-To: <88739f26-63b0-be1d-4e6d-def01633323e@virtuozzo.com>
On Thu, Feb 04, 2021 at 12:35:42AM +0300, Pavel Tikhomirov wrote:
>
> AFAICS if pid is held only by 1) fowner refcount and by 2) single process
> (without threads, group and session for simplicity), on process exit we go
> through:
>
> do_exit
> exit_notify
> release_task
> __exit_signal
> __unhash_process
> detach_pid
> __change_pid
> free_pid
> idr_remove
>
> So pid is removed from idr, and after that alloc_pid can reuse pid numbers
> even if old pid structure is still alive and is still held by fowner.
...
> Hope this answers your question, Thanks!
Yeah, indeed, thanks! So the change is sane still I'm
a bit worried about backward compatibility, gimme some
time I'll try to refresh my memory first, in a couple
of days or weekend (though here are a number of experienced
developers CC'ed maybe they reply even faster).
next prev parent reply other threads:[~2021-02-03 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 12:41 [PATCH] fcntl: make F_GETOWN(EX) return 0 on dead owner task Pavel Tikhomirov
2021-02-03 19:32 ` Cyrill Gorcunov
2021-02-03 21:35 ` Pavel Tikhomirov
2021-02-03 22:17 ` Cyrill Gorcunov [this message]
2021-02-08 12:31 ` Jeff Layton
2021-02-08 12:57 ` Pavel Tikhomirov
2021-02-08 13:18 ` Jeff Layton
2021-02-08 7:39 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203221726.GF2172@grain \
--to=gorcunov@gmail.com \
--cc=avagin@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.