Re: [PATCH v4 5/6] dm: add 'noexcl' option for dm-linear

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2936 bytes --]

Hi Sergei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.11-rc6 next-20210125]
[cannot apply to dm/for-next block/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sergei-Shtepa/block-layer-interposer/20210204-001245
base:   git://git.lwn.net/linux-2.6 docs-next
config: sparc-randconfig-s031-20210203 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/c4ced186119bdfd9330bbc8744a41d07ea477bbf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sergei-Shtepa/block-layer-interposer/20210204-001245
        git checkout c4ced186119bdfd9330bbc8744a41d07ea477bbf
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/md/dm-table.c:333:63: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected restricted fmode_t [usertype] mode @@     got bool [usertype] non_exclusive @@
   drivers/md/dm-table.c:333:63: sparse:     expected restricted fmode_t [usertype] mode
   drivers/md/dm-table.c:333:63: sparse:     got bool [usertype] non_exclusive

vim +333 drivers/md/dm-table.c

   318	
   319	/*
   320	 * This upgrades the mode on an already open dm_dev, being
   321	 * careful to leave things as they were if we fail to reopen the
   322	 * device and not to touch the existing bdev field in case
   323	 * it is accessed concurrently.
   324	 */
   325	static int upgrade_mode(struct dm_dev_internal *dd, fmode_t new_mode, bool non_exclusive,
   326				struct mapped_device *md)
   327	{
   328		int r;
   329		struct dm_dev *old_dev, *new_dev;
   330	
   331		old_dev = dd->dm_dev;
   332	
 > 333		r = dm_get_table_device(md, dd->dm_dev->bdev->bd_dev, non_exclusive,
   334					dd->dm_dev->mode | new_mode, &new_dev);
   335		if (r)
   336			return r;
   337	
   338		dd->dm_dev = new_dev;
   339		dm_put_table_device(md, old_dev);
   340	
   341		return 0;
   342	}
   343	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24859 bytes --]